feat(whiteboard): add tldraw support #205
Conversation
- Had to remove xml2js to te able to update react-scripts to 5.0 -- Replaced by https://goessner.net/download/prj/jsonxml/json2xml.js (with some small modifications) - Retro-compatible with old recordings
|
It looks great, @germanocaumo ! I'll try to take a look this weekend |
|
Maybe it would be a good opportunity to improve the tests over data's |
- RenderedBounds from tldrawAPI was not updating right away when switching from deskshare, use the size directly. - Refactor code a bit following suggestions from review
|
Another thing that is nice to do when a new whole component is included that has it's state controlled by the customs hooks is to check CPU usage while playing the recording. If you could compare CPU between tldraw and the current presentation (using similar annotations and stuff) we can anticipate some issues users might have. |
Yeah. I think this might be ok but BBB had an issue on it's deploy. The different versions of BBB weren't building from the playback tags. @antobinary could you check on that? |
|
I'll merge this to develop and create a new tag over the develop branch. Then I'll send a PR for BBB 2.6.x updating the playback source tag. Here's some extra details on my main concern described in the previous comment: I believe BBB 2.4 and bellow were monitoring the master branch changes to generate new packages. This is not ideal for many reasons. At this repository, tags are usually generated from the master branch, so we would find ourselves in a though position trying to test this feature with 2.6 alpha. |
pedrobmarin
requested review from
pedrobmarin
and removed request for
pedrobmarin
## What's Changed * feat(playback): move react-scripts to devDependencies by @frankemax in bigbluebutton/bbb-playback#199 * Add regional fallbacks for all languages by @MBM1607 in bigbluebutton/bbb-playback#201 * Replace ReactDOM.render with createRoot by @MBM1607 in bigbluebutton/bbb-playback#200 * chore: locales from upstream by @pedrobmarin in bigbluebutton/bbb-playback#204 * feat(whiteboard): add tldraw support by @germanocaumo in bigbluebutton/bbb-playback#205 ## New Contributors * @frankemax made their first contribution in bigbluebutton/bbb-playback#199 * @MBM1607 made their first contribution in bigbluebutton/bbb-playback#201 **Full Changelog**: bigbluebutton/bbb-playback@v4.0.0...v5.0.0-alpha.1
|
Thanks a lot @pedrobmarin!!! ✨ |
Uses the events and files from bigbluebutton/bigbluebutton#15244
-- Replaced by https://goessner.net/download/prj/jsonxml/json2xml.js (with some small modifications)
Closes #191.
23-06-2022-39wk0_Trim.mp4