Add persisted id to payload #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
commented
Oct 5, 2016
| (work, '../work/{}', 'work')]: | ||
| ld_data = entity.to_jsonld() | ||
| ld_data['@id'] = id_template.format(entity.persist_id) | ||
| res[key] = ld_data |
There was a problem hiding this comment.
This is somewhat messy, since we have to use the relative URL here if we want to be JSON-LD compliant (related #14). It's not as nice as having just the ID, but stripping the path to get the ID is easy enough and I prefer this over a few alternatives on where to put the ID.
sohkai
force-pushed
the
feat/15/add-persisted-id-to-payload
branch
from
b7dbb8a to
202d26f
Compare
|
Also part of the fix for COALAIP/pycoalaip#45. |
TimDaub
suggested changes
Oct 14, 2016
|
|
||
| In the case of the returned Work and Copyright, their `@id`s are slightly | ||
| inconvenient to process as they live under a different base URL (`/work` and | ||
| `/right`, respectively). You should strip awsay the leading pathes to use just |
| assert bool(manifestation['manifestationOfWork']) is True | ||
|
|
||
| # Check @ids | ||
| assert copyright_['@id'].startswith('../right/') |
There was a problem hiding this comment.
Sorry if I'm misunderstanding this but shouldn't this link relatively to another bigchaindb transaction instead of .../right/?
There was a problem hiding this comment.
No; the relative link is based on the URL of the current request, which in this case is <coala-http-api>/api/v1/manifestation/<id>
TimDaub
approved these changes
Nov 8, 2016
TimDaub
force-pushed
the
feat/15/add-persisted-id-to-payload
branch
from
2de2ccb to
935ab51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15.
Blocks #5.