Transfer a right #17
Transfer a right #17
Conversation
web/views/rights.py
Outdated
| except ModelDataError: | ||
| right = models.Copyright.from_persist_id(right_id, | ||
| plugin=coalaip.plugin, | ||
| force_load=True) |
There was a problem hiding this comment.
This isn't super nice with the way I've set up Rights and Copyrights in pycoalaip, but it's either something like this where we do a best-effort guess or ask the user to supply the type of the Right.
The main issue is that, at the end of they day, we can never be 100% sure what an entity's type is if they haven't explicitly stated it themselves (@type breaks due to Manifestations able to be any submodel of CreativeWork).
README.md
Outdated
| }, | ||
| "to": { | ||
| "verifyingKey": "<base58 string>", | ||
| "signingKey": "<base58 string>" |
There was a problem hiding this comment.
Why do we have to send a signingKey to transfer?
There was a problem hiding this comment.
pycoalaip's interface requires it; it expects a full user model regardless of whether or not that's necessary.
There was a problem hiding this comment.
We can omit the signingKey since it's never used. I'd prefer to keep it in the dict, but set to null, so that the payload still matches pycoalaip-bigchaindb's user model.
tests/test_api.py
Outdated
| 'action': 'loan', | ||
| }, | ||
| 'currentHolder': alice, | ||
| 'to': bob, |
There was a problem hiding this comment.
We should just pass bob's verifyingKey
sohkai
force-pushed
the
feat/5/transfer-a-right
branch
2 times, most recently
from
6e2748c to
3c1f65f
Compare
sohkai
force-pushed
the
feat/5/transfer-a-right
branch
3 times, most recently
from
7fde8c2 to
5be8368
Compare
| PAYLOAD: | ||
| { | ||
| "rightId": "<ID of an existing Right to transfer; must be held by the user specified in `currentHolder`>", | ||
| "rightsAssignment": { |
There was a problem hiding this comment.
If we'd add a document or sentence here that would state the conditions under which the Right is transferred, we'd also solve #6.
| headers={'Content-Type': 'application/json'}) | ||
|
|
||
| # Sleep for a bit to let the transaction become valid | ||
| sleep(3) |
| plugin=coalaip.plugin, | ||
| force_load=True) | ||
| except ModelDataError: | ||
| right = entities.Copyright.from_persist_id(right_id, |
There was a problem hiding this comment.
cool, we can transfer a copyright as well!
sohkai
force-pushed
the
feat/5/transfer-a-right
branch
4 times, most recently
from
2dcade2 to
0bf899a
Compare
sohkai
force-pushed
the
feat/5/transfer-a-right
branch
from
0bf899a to
bbe8ec0
Compare
Fixes #5, fixes #6.
Builds on #25.
Needs to wait for COALAIP/pycoalaip-bigchaindb#18 before getting merged.