Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: company subsidiaries and permission #184

Open
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

BrianJiang2021
Copy link
Collaborator

@BrianJiang2021 BrianJiang2021 commented Dec 12, 2024

Jira: B2B-1567
Jira: B2B-1565
Jira: B2B-1656
Jira: B2B-1657

Jira: B2B-1566
Jira: B2B-1564

Jira: B2B-1782

Jira: B2B-1705

Jira: B2B-1871
Jira: B2B-1872
Jira: B2B-1873
Jira: B2B-1874
Jira: B2B-1875
Jira: B2B-1876

What/Why?

add the CompanySubsidiaries interface
display the"Switch Company" Panel on Buyer Portal
add constans z-index

aggregated view for Orders & Invoices

company Hierarchy permission optimization
add Settings in Django Admin to Control Account Hierarchy

Advanced buyer permission level on buyer portal
Mainly includes address, user management, shoppingList, quote and other pages;
In addition, there are control permissions for purchase, ShoppingList and quote buttons
Correct spelling errors

Rollout/Rollback

undo pr

Testing

B2B-1565-all.mp4

@BrianJiang2021 BrianJiang2021 changed the title Feat/b2 b 1565 feat: company subsidiaries and permission Dec 12, 2024
Copy link
Contributor

@bc-micah bc-micah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a lot of concerns with this PR.

It feels very unfinished and logic is spread out in a lot of places.
Also the API seems to not be returning data correctly, and each component is then parsing out lists etc (i.e permission.split(',')[0].trim() type things).

This is not ready to merge.

I will try to provide more feedback on Monday.
For now - we will only release this via Tier 1 till we fix all these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants