-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styled components 6 bump poc #1335
Draft
leeBigCommerce
wants to merge
44
commits into
main
Choose a base branch
from
styled-components-6-bump-poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeBigCommerce
force-pushed
the
styled-components-6-bump-poc
branch
from
January 24, 2024 23:13
653e401
to
634d6e2
Compare
leeBigCommerce
force-pushed
the
styled-components-6-bump-poc
branch
6 times, most recently
from
February 6, 2024 04:18
f88c62a
to
40cd2e7
Compare
…tylis to all packages
leeBigCommerce
force-pushed
the
styled-components-6-bump-poc
branch
from
February 6, 2024 05:15
40cd2e7
to
5d7cc01
Compare
…o restyled components
…horts for ProgressCircle
leeBigCommerce
force-pushed
the
styled-components-6-bump-poc
branch
from
February 6, 2024 05:44
5d7cc01
to
3325667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Describe what changes you are making. e.g.
Adds X prop in the Box component.
Why?
Please provide the reason(s) why you are making this change? Please no one-liners like,
It was missing.
; expand upon the reason like,Adds X prop because it was missing in the Box component. Documentation notes this prop exists, but it actually wasn't implemented.
Screenshots/Screen Recordings
This is a component library so we love visually looking at changes! If this applies to your pull request, show us your hard work in action.
Testing/Proof
Explain how you tested your new feature or bugfix. Please refrain from one-liners like,
Added tests.
; expand upon how you tested your changes like,Added local tests to the new component and ensured test coverage was met. Manually tested on [email protected].
.