chore: expose the controls label for localization within Table #1603
+39
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 141650b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
leeBigCommerce
force-pushed
the
ORDERS-6678-table-controls-label
branch
from
86a64e2 to
58275c3
Compare
leeBigCommerce
force-pushed
the
ORDERS-6678-table-controls-label
branch
from
58275c3 to
141650b
Compare
chanceaclark
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
controlsLabelwithin thelocalizationoptions ofTablelocalizationdefinitionWhy?
Table Controlwas previous hardcoded and uneditablelocalizationdefinition is backwards compatible and allows clients to localize as much, or as little, of the texts as they wishN.B.
controlsLabelis a non-visible, accessibility only label which surrounds the pagination and limit actionsScreenshots/Screen Recordings
This is a component library so we love visually looking at changes! If this applies to your pull request, show us your hard work in action.
Testing/Proof