feat(payment): PAYPAL-4937 Update PaymentRequestSender with new GQL API #2754
Conversation
…ng an additional method
bc-nick
requested review from
serhii-tkachenko,
andriiVitvitskyi1990,
davidchin,
animesh1987 and
bc-peng
| @@ -0,0 +1,6 @@ | |||
| export default interface HeadlessPaymentMethod<T = any> { | |||
There was a problem hiding this comment.
Can any type be changed to unknown?
There was a problem hiding this comment.
Would be better to use the any type in this case for matching initializationData type with PaymentMethod interface which also uses any for initializationData.
| @@ -0,0 +1,7 @@ | |||
| import HeadlessPaymentMethod from './headless-payment-method'; | |||
|
|
|||
| export interface HeadlessPaymentMethodResponse<T = any> { | |||
There was a problem hiding this comment.
Will it work for you, if any be changed with unknown?
| export interface HeadlessPaymentMethodResponse<T = any> { | |
| export interface HeadlessPaymentMethodResponse<T = unknown> { |
There was a problem hiding this comment.
Are we not able to define the actual type here?
There was a problem hiding this comment.
@bc-peng removed T parameter as unnecessary in this case. we can define type as string
| import HeadlessPaymentMethodConfig from './headless-payment-method-config'; | ||
| import { HeadlessPaymentMethodResponse } from './headless-payment-method-response'; | ||
| import { HeadlessPaymentMethodType } from './headless-payment-method-type'; | ||
| import HeadlessPaymentRequestOptions from './headless-payment-request-options'; |
There was a problem hiding this comment.
Can we group them into a headless-payment folder for better orgnization as I can see things are quite different here?
There was a problem hiding this comment.
Moved to the separate folder
| methodId: string, | ||
| options: HeadlessPaymentRequestOptions, | ||
| ): Promise<Response<PaymentMethod>> { | ||
| const url = `/graphql`; |
| if (!entityId) { | ||
| throw new Error('Unable to get payment entity id.'); | ||
| } |
There was a problem hiding this comment.
What would happen after throwing this error?
There was a problem hiding this comment.
We are not be able to make a request in this case. It will be catch with PaymentMethodActionCreator when i add it by the next PR
| }; | ||
| } | ||
|
|
||
| private getPaymentEntityId(methodId: string): HeadlessPaymentMethodType { |
There was a problem hiding this comment.
| private getPaymentEntityId(methodId: string): HeadlessPaymentMethodType { | |
| private _getPaymentEntityId(methodId: string): HeadlessPaymentMethodType { |
| .then((response) => this.transformToPaymentMethodResponse(response, methodId)); | ||
| } | ||
|
|
||
| private transformToPaymentMethodResponse( |
There was a problem hiding this comment.
| private transformToPaymentMethodResponse( | |
| private _transformToPaymentMethodResponse( |
There was a problem hiding this comment.
Also maybe refactor this to a separate transformer file.
There was a problem hiding this comment.
Moved to the separate file
| const graphQLQuery = ` | ||
| query { | ||
| site { | ||
| paymentWalletWithInitializationData(filter: {paymentWalletEntityId: "${entityId}"}) { |
There was a problem hiding this comment.
| paymentWalletWithInitializationData(filter: {paymentWalletEntityId: "${entityId}"}) { | |
| paymentWalletWithInitializationData(filter: { paymentWalletEntityId: "${entityId}"}) { |
What?
Updated
PaymentMethodRequestSenderby adding an additional methodUpdated
PaymentMethodActionCreatorby adding an additional methodWhy?
As part of the implementation of Headless Wallet Buttons (POC)
Testing / Proof
Manual
@bigcommerce/team-checkout @bigcommerce/team-payments