-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVDOCS-6170 - [New Doc] Guide for PCI on Checkout #820
Conversation
Providing a developer guide for updating custom checkout to include PCI DSS 4.0 Section 6.4.3 compliance features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no real comments, and I think it looks great. One thing I notice though is the url is open-checkouts
plural but the navigation in the dev docs is singular open-checkout
Don't think it's that important but it cought my eye
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
- Remove extra space - Change "Channel Manager" to "Channels"
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bc-terra good technical article. I made some editorial suggestions.
The style guide specifies to use control panel, not Control Panel.
I had chatgpt to review it as well. Maybe you can talk to the team about the feedback and if it is needed incorporate it later. The feedback was the following:
- In Step 2, it assumes there is prior knowledge about how the
openssl
command works. Consider adding a brief explanation of whatopenssl
is doing. - In Step 4, you might want to add a clarification that nonce values are dynamically generated for each request and should not be hardcoded. Also explain why nonce-based authorization is required under PCI DSS 4.0.
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
…ide.mdx Co-authored-by: Traci Porter <[email protected]>
…ide.mdx Co-authored-by: Traci Porter <[email protected]>
…ide.mdx Co-authored-by: Traci Porter <[email protected]>
…ide.mdx Co-authored-by: Traci Porter <[email protected]>
…ide.mdx Co-authored-by: Traci Porter <[email protected]>
…ide.mdx Co-authored-by: Traci Porter <[email protected]>
…ide.mdx Co-authored-by: Traci Porter <[email protected]>
…ide.mdx Co-authored-by: Traci Porter <[email protected]>
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
docs/storefront/cart-checkout/open-checkouts/pci-compliance-guide.mdx
Outdated
Show resolved
Hide resolved
Added reference for OpenSSL command line to the links, as this doc does assume some level of knowledge, but resources are always helpful. Added statement about purpose of nonce-based authorization with respect to PCI 4.0 and a callout that values are randomly generated and not to be stored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @bc-terra
Providing a developer guide for updating custom checkout to include PCI DSS 4.0 Section 6.4.3 compliance features
DEVDOCS-6170
What changed?
Release notes draft
Anything else?
SME review waived by GTM team.
Navigation update to be requested and managed separately.
ping {names}