Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-6170 - [New Doc] Guide for PCI on Checkout #820

Merged
merged 13 commits into from
Feb 17, 2025
Merged

Conversation

bc-terra
Copy link
Contributor

@bc-terra bc-terra commented Feb 13, 2025

Providing a developer guide for updating custom checkout to include PCI DSS 4.0 Section 6.4.3 compliance features

DEVDOCS-6170

What changed?

  • PCI DSS 4.0 Section 6.4.3 requires the inclusion of nonce-based authentication and SRI for checkout pages
  • BigCommerce provides this functionality via updated features in control panel settings and Open Checkouts
  • This provides a guide for developers for the use of the functionality.

Release notes draft

  • Created new guide for setting up PCI compliant features on checkout

Anything else?

SME review waived by GTM team.
Navigation update to be requested and managed separately.

ping {names}

Providing a developer guide for updating custom checkout to include PCI DSS 4.0 Section 6.4.3 compliance features
Copy link
Contributor

@bc-0dp bc-0dp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no real comments, and I think it looks great. One thing I notice though is the url is open-checkouts plural but the navigation in the dev docs is singular open-checkout

Don't think it's that important but it cought my eye

- Remove extra space
- Change "Channel Manager" to "Channels"
@bc-terra bc-terra added the ready for review This PR is complete and awaiting a review. label Feb 14, 2025
Copy link
Collaborator

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bc-terra good technical article. I made some editorial suggestions.
The style guide specifies to use control panel, not Control Panel.

I had chatgpt to review it as well. Maybe you can talk to the team about the feedback and if it is needed incorporate it later. The feedback was the following:

  • In Step 2, it assumes there is prior knowledge about how the openssl command works. Consider adding a brief explanation of what openssl is doing.
  • In Step 4, you might want to add a clarification that nonce values are dynamically generated for each request and should not be hardcoded. Also explain why nonce-based authorization is required under PCI DSS 4.0.

@bc-terra
Copy link
Contributor Author

  • In Step 2, it assumes there is prior knowledge about how the openssl command works. Consider adding a brief explanation of what openssl is doing.
  • In Step 4, you might want to add a clarification that nonce values are dynamically generated for each request and should not be hardcoded. Also explain why nonce-based authorization is required under PCI DSS 4.0.

Added reference for OpenSSL command line to the links, as this doc does assume some level of knowledge, but resources are always helpful.

Added statement about purpose of nonce-based authorization with respect to PCI 4.0 and a callout that values are randomly generated and not to be stored.

Copy link
Collaborator

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @bc-terra

@bc-terra bc-terra merged commit dfaef03 into main Feb 17, 2025
3 checks passed
@bc-terra bc-terra deleted the bc-terra-patch-2 branch February 17, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is complete and awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants