Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update products_catalog.v3.yml #826

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

bc-romanliukshyn
Copy link
Contributor

@bc-romanliukshyn bc-romanliukshyn commented Feb 17, 2025

DEVDOCS-6265

What changed?

  • the include param should not mention a limit of 10 items per page - this is relevant to Get All Products endpoint only
  • videos resource is added

Release notes draft

Anything else?

ping {names}

Copy link
Collaborator

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bc-romanliukshyn bc-romanliukshyn merged commit a293d22 into main Feb 17, 2025
3 checks passed
@bc-romanliukshyn bc-romanliukshyn deleted the bc-romanliukshyn-patch-1 branch February 17, 2025 18:51
@bc-traciporter
Copy link
Collaborator

@bc-romanliukshyn Thanks for adding videos as a resource for the include parameter. I am thinking that I should not mention this addition in the release notes, correct?

@bc-romanliukshyn
Copy link
Contributor Author

Hi @bc-traciporter , I am not sure if we need to mention this since the videos param was in fact always working and videos were available in the response before this update.

@bc-traciporter
Copy link
Collaborator

@bc-romanliukshyn great, I won't mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants