Add base implementation for Ledger wallet #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fsodano
commented
Aug 4, 2022
•
fsodano
commented
* Remove debug messages * Add tests * Fix issue where getPublicKey was being triggered twice
fsodano
changed the title
Ja-boop
approved these changes
Aug 19, 2022
Genebson
reviewed
Aug 19, 2022
| cy.get('.simple-signer-container').as('container'); | ||
| }); | ||
| it("Should check if there's five connect methods", () => { | ||
| it('Should should display the connect methods', () => { |
There was a problem hiding this comment.
I think the should word is duplicated.
Ja-boop
reviewed
Aug 19, 2022
| @@ -23,11 +23,11 @@ export default class Albedo extends AbstractWallet implements IWallet { | |||
| } | |||
|
|
|||
| public override async getPublicKey(): Promise<string> { | |||
| const requestPubKey = await window.albedo.publicKey({ | |||
| const { pubkey } = await window.albedo.publicKey({ | |||
There was a problem hiding this comment.
This shouldn't be in camelCase? Just like the others wallets?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.