-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bitfit #311
Open
Muennighoff
wants to merge
19
commits into
main
Choose a base branch
from
bitfit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Bitfit #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility for BitFit. I'd like to try BitFit + MTF to retain Multilinguality.
Empirical evidence from this paper:
Note that adapters also add parameters to the model & increase complexity at inference in Transformers, so BF is the best option imo.
Also see this paper though they don't try BitFit.
Automatic Tests: Happy to add one if we decide to merge this 🤗
Manual Tests:
The below shows how the grad norm decreases as it should, because we have less gradients.
I would also expect time to decrease due to less communication, but probably only at more nodes.
Memory usage also decreases due to less optimizer states to store.
With BitFit, 2 Nodes, PP=2, TP=2
Without BitFit