New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various small problems #367

Open

janEbert wants to merge 3 commits into bigscience-workshop:main from janEbert:misc-fixes

Collaborator

janEbert commented Feb 28, 2023

Problems:

BERT/T5 dataset handles already corrupted indices incorrectly.
GPT tokenizer vocab size does not include special tokens.
In Eval Harness evaluation, the last token of the target is unconditionally truncated. This results in wrong evaluation metrics and is actually not such a small problem.

This PR fixes these issues. Since the changes are so small, I didn't bother creating 3 PRs.

janEbert added 3 commits

February 28, 2023 17:36


          Fix covered index skipping

ce3f6c0


          Fix GPT tokenizer vocab size query

f7c583f

Did not include additional special tokens.


          Do not remove last token

cfd6374

This corrupts the targets. There is no good reason for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet