typing for defineExtension
should allow partials
#3030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docs for custom extensions show:
https://htmx.org/extensions/building/
However the current typing doesn't allow this - it requires a fully populated
HtmxExtension
object defining all the methods:Testing
I made a working extension in my project and ignored the typing errors. (This is what prompted making this PR)
Changing the type to
Partial<HtmxExtension>
in my installed copy ofhtmx.esm.d.ts
makes the typing errors go away and seems to reflect intended usage.Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded