Video single frame annotation #1019

aneust · 2024-12-19T20:48:46Z

Add a settings option to the video annotation tool to automatically finish new annotations after the first frame

Add button to settings
Add description in manual
Disabled "Finish" and "Track Annotation" control buttons, when option is activated
Prevented double-click behavior for point annotations

closes #786

…click point

mzur · 2025-01-06T08:42:10Z

@aneust Was this closed on purpose?

aneust · 2025-01-06T09:31:38Z

@mzur Closed on purpose, Leane found some strange behavior I first could not reproduce. Think now it was caused by the settings.

mzur · 2025-01-06T10:33:10Z

Ok, thanks. You could also keep this as a Draft PR while you keep working on the issue.

lehecht · 2025-01-14T10:47:26Z

Regarding the issue with the sketch lines:
The sketch lines don't disappear, because finishDrawAnnotation is called before the annotation could be completely added to this.pendingAnnotationSource. You need to use this.pendingAnnotationSource.once('addfeature', this.finishDrawAnnotation); here. It calls finishDrawAnnotation after the annotation was added to that source.
I hope it helps. If there is still or another problem, let me know!

aneust · 2025-01-14T13:09:50Z

@lehecht Thanks, that was helpful!

resources/assets/js/videos/components/videoScreen/drawInteractions.vue

resources/views/videos/show/sidebar-settings.blade.php

resources/views/manual/tutorials/videos/sidebar.blade.php

resources/assets/js/videos/components/videoScreen/drawInteractions.vue

resources/assets/js/videos/components/videoScreen.vue

resources/assets/js/videos/components/videoScreen/drawInteractions.vue

resources/assets/js/videos/components/videoScreen.vue

resources/assets/js/videos/components/videoScreen/drawInteractions.vue

resources/assets/js/videos/components/videoScreen.vue

- update computed properties for better readability

lehecht

Looks good to me now. Please request a review from @mzur.

mzur · 2025-01-31T10:50:23Z

I saw the mention and self-requested the review 😉 @lehecht You can also request the review from me when you are done.

mzur

Two comments about the UI:

The setting doesn't affect whole-frame annotations but it should.
To be more user-friendly, the "finish annotation" and "track annotation" buttons (which are disabled) could get titles like "Disable the single-frame annotation option to create multi-frame annotations" ("Disable the single-frame annotation option to track annotations"). This way users are reminded of what to do if they want to use the buttons again. You could implement this with v-if showing a completely different set of buttons which are always disabled and have the new title.

Otherwise it works great. See some comments about the code below.

mzur · 2025-01-31T11:05:40Z

resources/assets/js/videos/components/videoScreen/drawInteractions.vue

-                this.pendingAnnotation.frames.push(this.video.currentTime);
-                this.pendingAnnotation.points.push(this.getPointsFromGeometry(e.feature.getGeometry()));
+                if (this.singleAnnotation && this.isPointDoubleClick(e)) { 
+                    this.pendingAnnotationSource.once('addfeature', function (e) {


Please add the explanation:

// The feature is added to the source only after this event // is handled, so remove has to happen after the addfeature // event.

mzur · 2025-01-31T11:08:47Z

resources/assets/js/videos/components/videoScreen/drawInteractions.vue

+                if (this.singleAnnotation && this.isPointDoubleClick(e)) { 
+                    this.pendingAnnotationSource.once('addfeature', function (e) {
+                        this.removeFeature(e.feature);
+                    });


Shouldn't you return here and skip the rest of the function?

mzur · 2025-01-31T11:09:50Z

resources/assets/js/videos/components/videoScreen/drawInteractions.vue

+import { computeDistance } from '../../utils';

 /**
 * Mixin for the videoScreen component that contains logic for the draw interactions.
 *
 * @type {Object}
 */
+
+const POINT_CLICK_COOLDOWN = 400;
+const POINT_CLICK_DISTANCE = 5;
+


Since computeDistance and the constants are used both in the image annotation tool and the video annotation tool, please create a new file for these and reuse the same function/constants in both tools.

mzur · 2025-01-31T11:10:45Z

resources/assets/js/videos/components/videoScreen/drawInteractions.vue

@@ -199,13 +213,19 @@ export default {
            let lastFrame = this.pendingAnnotation.frames[this.pendingAnnotation.frames.length - 1];

            if (lastFrame === undefined || lastFrame < this.video.currentTime) {
-                this.pendingAnnotation.frames.push(this.video.currentTime);
-                this.pendingAnnotation.points.push(this.getPointsFromGeometry(e.feature.getGeometry()));
+                if (this.singleAnnotation && this.isPointDoubleClick(e)) { 


Don't you have to check this.isDrawingPoint here, too?

mzur · 2025-01-31T11:11:48Z

resources/assets/js/videos/components/videoScreen/drawInteractions.vue

+            if (this.singleAnnotation) {
+                if (this.isDrawingPoint) {
+                    if (this.isPointDoubleClick(e)) {
+                        this.resetPendingAnnotation(this.pendingAnnotation.shape);
+                        return;
+                    }
+                    this.lastDrawnPointTime = new Date().getTime();
+                    this.lastDrawnPoint = e.feature.getGeometry();
+                }
+                this.pendingAnnotationSource.once('addfeature', this.finishDrawAnnotation);
+            }


I feel all this can be added to the if above when refactored appropriately. This also would add the ´return` I asked for above.

mzur · 2025-01-31T11:14:20Z

resources/views/videos/show/sidebar-settings.blade.php

@@ -52,6 +52,10 @@
                <div class="sidebar-tab__section">
                    <power-toggle :active="muteVideo" title-off="Mute video" title-on="Unmute video" v-on:on="handleMuteVideo" v-on:off="handleUnmuteVideo">Mute Video</power-toggle>
                </div>
+
+                <div class="sidebar-tab__section">
+                    <power-toggle :active="singleAnnotation" title-off="Enable Single-Frame Annotation" title-on="Disable Single-Frame Annotation" v-on:on="handleSingleAnnotation" v-on:off="handleDisableSingleAnnotation">Single-Frame Annotation</power-toggle>


The title is not very helpful. What about "Enable always creating single-frame annotations" (and "Disable ...")?

aneust added 3 commits December 19, 2024 21:08

Add Single-Frame Annotation button to settings

787630e

Add description for Single-Frame Annotation option

867a7bd

Add single frame annotation, disable control buttons, prevent double-…

f4d4478

…click point

aneust marked this pull request as ready for review December 19, 2024 20:54

aneust requested a review from lehecht December 19, 2024 20:54

aneust closed this Dec 25, 2024

aneust reopened this Jan 7, 2025

aneust removed the request for review from lehecht January 7, 2025 09:33

remove duplication

9f6ec6d

aneust added 2 commits January 14, 2025 15:22

Fix sketch line problem, rework double-click handling

231fa11

Merge branch 'master' into videoAnnotation

5261bf0

aneust requested a review from lehecht January 14, 2025 14:37

lehecht requested changes Jan 15, 2025

View reviewed changes

aneust added 2 commits January 28, 2025 15:49

Implement requested changes

a79da52

Removed unused import

3cd67f8

aneust requested a review from lehecht January 28, 2025 15:06

lehecht requested changes Jan 29, 2025

View reviewed changes

Implement requested changes

97b7239

- update computed properties for better readability

aneust requested a review from lehecht January 30, 2025 16:28

lehecht reviewed Jan 31, 2025

View reviewed changes

mzur self-requested a review January 31, 2025 10:49

mzur reviewed Jan 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Video single frame annotation #1019

Video single frame annotation #1019

aneust commented Dec 19, 2024

mzur commented Jan 6, 2025

aneust commented Jan 6, 2025

mzur commented Jan 6, 2025

lehecht commented Jan 14, 2025

aneust commented Jan 14, 2025

lehecht left a comment

mzur commented Jan 31, 2025

mzur left a comment

mzur Jan 31, 2025

mzur Jan 31, 2025

mzur Jan 31, 2025

mzur Jan 31, 2025

mzur Jan 31, 2025

mzur Jan 31, 2025

Video single frame annotation #1019

Are you sure you want to change the base?

Video single frame annotation #1019

Conversation

aneust commented Dec 19, 2024

mzur commented Jan 6, 2025

aneust commented Jan 6, 2025

mzur commented Jan 6, 2025

lehecht commented Jan 14, 2025

aneust commented Jan 14, 2025

lehecht left a comment

Choose a reason for hiding this comment

mzur commented Jan 31, 2025

mzur left a comment

Choose a reason for hiding this comment

mzur Jan 31, 2025

Choose a reason for hiding this comment

mzur Jan 31, 2025

Choose a reason for hiding this comment

mzur Jan 31, 2025

Choose a reason for hiding this comment

mzur Jan 31, 2025

Choose a reason for hiding this comment

mzur Jan 31, 2025

Choose a reason for hiding this comment

mzur Jan 31, 2025

Choose a reason for hiding this comment