🤖 Merge PR DefinitelyTyped#71537 Fix typing of addKeyBinding() for re…

…veal.js by @kcooney
bikehara-ias · Jan 25, 2025 · 05315e4 · 05315e4
1 parent f5afe14
commit 05315e4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/types/reveal.js/index.d.ts b/types/reveal.js/index.d.ts
@@ -653,8 +653,8 @@ declare namespace Reveal {
          * @param callback
          */
         addKeyBinding(
-            binding: string | { keyCode: number; key: string; description: string },
-            callback: (event: KeyboardEvent) => void,
+            keyCode: number | { keyCode: number; key: string; description: string },
+            callback: string | ((event: KeyboardEvent) => void),
         ): void;
 
         /**

diff --git a/types/reveal.js/reveal.esm.js-tests.ts b/types/reveal.js/reveal.esm.js-tests.ts
@@ -794,7 +794,10 @@ deck.hasNavigatedVertically();
 // Adds/removes a custom key binding
 
 // $ExpectType void
-deck.addKeyBinding("enter", () => {});
+deck.addKeyBinding(82, () => {});
+
+// $ExpectType void
+deck.addKeyBinding(82, "next");
 
 // $ExpectType void
 deck.addKeyBinding({ keyCode: 1, key: "enter", description: "description" }, () => {});

diff --git a/types/reveal.js/reveal.js-tests.ts b/types/reveal.js/reveal.js-tests.ts
@@ -826,7 +826,10 @@ deck.hasNavigatedVertically();
 // Adds/removes a custom key binding
 
 // $ExpectType void
-deck.addKeyBinding("enter", () => {});
+deck.addKeyBinding(82, () => {});
+
+// $ExpectType void
+deck.addKeyBinding(82, "next");
 
 // $ExpectType void
 deck.addKeyBinding({ keyCode: 1, key: "enter", description: "description" }, () => {});