Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify OnRunCompleted waits for pipeline to complete #489

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

drewburlingame
Copy link
Collaborator

an attempt to verify #488.

@Sibusten can you post a failing test or point to a repo where this is failing? I updated a test that seems to verify OnRunCompleted is called only after the pipeline is executed. I might be missing something.

@Sibusten
Copy link

Here's a reproduction of the issue which shows disposal before the command finishes
https://github.com/Sibusten/commanddotnet-488-repro
2023-11-27_20-57-24

If you change the command in the test to async Task Do and await the Task.Delay you should see the issue. Right now the test is not waiting for the delay to finish because that task is not being awaited.

@drewburlingame drewburlingame merged commit 8e2fb71 into master Dec 9, 2023
6 checks passed
@drewburlingame drewburlingame deleted the 488-on-run-completed-waits branch December 9, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants