Added the log level argument to the parser (-l, --log) which by default ... #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt is INFO. The reason for this is to disable DEBUG level logging by default, since a performance degradation was found when collating large volumes of incoming messages. Additionally, both the address and port arguments were given the (-a, --addr // -p, --port) argument options and were both set to required. A basic call to dispatch would look like $ python dasinbox.py --addr 0.0.0.0 --port 4467 --log info or $ python dasinbox.py -a 0.0.0.0 -p 4467 -l info Of course, INFO can be replaced with the following choices (critical, error, warning, notice, info, debug)
|
Bump. I think this is interesting as my log files are full of email bodies and growing pretty big. |
|
This has been hanging around for quite some time @kennethreitz - any plans on merging it in? :) |
wowkin2
reviewed
Feb 8, 2017
| parser.add_argument('port', metavar='port', type=int, help='port to bind to') | ||
| parser.add_argument('-a', '--addr', metavar='addr', type=str, help='addr to bind to', required=True) | ||
| parser.add_argument('-p', '--port', metavar='port', type=int, help='port to bind to', required=True) | ||
| parser.add_argument('-l', '--log', metavar='log', type=str, help='logging level (%s)' % (','.join(log_choices)), default='info', choices=log_choices) |
There was a problem hiding this comment.
You are using tabs instead of spaces here, please fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...is INFO. The reason for this is to disable DEBUG level logging by default, since a performance degradation was found when collating large volumes of incoming messages.
Additionally, both the address and port arguments were given the (-a, --addr // -p, --port) argument options and were both set to required.
A basic call to dispatch would look like
$ python dasinbox.py --addr 0.0.0.0 --port 4467 --log info
or
$ python dasinbox.py -a 0.0.0.0 -p 4467 -l info
Of course, INFO can be replaced with the following choices (critical, error, warning, notice, info, debug)