-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes #48
base: master
Are you sure you want to change the base?
Changes #48
Conversation
Waiting for the rest of the issues to be addressed as per email: Just thinking also, the references to "Fascicle n" we have (there will be quite a few), if we're changing the names of the book parts (Ben mentioned using the Part n format, check with him), then we will also need to change these. There is also other text you're changing the "formulate their exploits for you refer the sub-section" needs to be "formulate their exploits for you, refer to the sub-section" Point 20 still isn't addressed. If this needs to be in there, why not add these changes to a new branch of your fork -> issue pull request to the upstream packt branch. Point 22 in regards to the indentation, still needs to be less nested (2 or more characters less). Point 25 still needs to be done. "A 10,000' view scenario" should be "A 10,000' View Scenario", again as per source. "4. SSM risks that Solution Causes" should be "4. SSM Risks that Solution Causes". "5. SSM Costs and Trade-offs" I am noticing some inconsistencies in our list item full stop rational, I've just checked this with Russ, I'll let you know the outcome once I get a response. No full stops at the end of list items ever. See answers inline.................
[KC] Looks like it's still glitching, 30000' is supposed to have a ',' (comma)
[KC] Thanks, but it is no longer italicised. Can we have it the same format but bold, not a different format and bold?
[KC] They are still about two characters too deep. When you get to the next book part, and we have deeper nesting, this becomes really important, and we really need to stick with the same depth right throughout the book series. This is still observed in my point 18. Please pull them out at least two characters.
[KC] No now you have two the's "and the the Intel Threat Agent Library"
[KC] But you haven't. Point 27 "The first list in 30,000' chapter has added full stops". |
Have removed all full stops at end of list items. Please fetch -> merge latest before making additional changes. |
Please resolve conflicts. |
No description provided.