-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set IFS to default before use in compiler. #734
Conversation
Signed-off-by: Bolun Thompson <[email protected]>
OS = |
OS:ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Very neat! Happy to merge once you deanonymize the test string (see comment) :)
@@ -0,0 +1,5 @@ | |||
IFS=/ | |||
curr_dir=/home/bolun/programming/pash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could "deanonymize" this by making this string to be /test1/test2/test3/test4
?
Signed-off-by: Bolun Thompson <[email protected]>
acef4f6
to
6d6b29f
Compare
OS = |
OS:ubuntu-20.04 |
OS = |
OS:ubuntu-20.04 |
Resolves #718. In a few places, the default value of IFS is assumed, leading to pa.sh crashing when it’s reset. This saves the old IFS and restores it after the word splitting.