Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IFS to default before use in compiler. #734

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

BolunThompson
Copy link
Contributor

Resolves #718. In a few places, the default value of IFS is assumed, leading to pa.sh crashing when it’s reset. This saves the old IFS and restores it after the word splitting.

Copy link

OS =
CPU =
Ram =
Hash = 490e0a1
Kernel=
||
|-|-|-|-|-|-|-|-|-|

Copy link

OS:ubuntu-20.04
Mon Nov 18 23:53:10 UTC 2024
intro: 2/2 tests passed.
interface: 42/42 tests passed.
compiler: 54/54 tests passed.

Copy link
Member

@angelhof angelhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Very neat! Happy to merge once you deanonymize the test string (see comment) :)

@@ -0,0 +1,5 @@
IFS=/
curr_dir=/home/bolun/programming/pash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could "deanonymize" this by making this string to be /test1/test2/test3/test4?

Signed-off-by: Bolun Thompson <[email protected]>
Copy link

OS =
CPU =
Ram =
Hash = acef4f6
Kernel=
||
|-|-|-|-|-|-|-|-|-|

Copy link

OS:ubuntu-20.04
Tue Nov 19 00:29:16 UTC 2024
intro: 2/2 tests passed.
interface: 42/42 tests passed.
compiler: 54/54 tests passed.

Copy link

OS =
CPU =
Ram =
Hash = 6d6b29f
Kernel=
||
|-|-|-|-|-|-|-|-|-|

Copy link

OS:ubuntu-20.04
Tue Nov 19 00:31:01 UTC 2024
intro: 2/2 tests passed.
interface: 42/42 tests passed.
compiler: 54/54 tests passed.

@angelhof angelhof merged commit 570ffdc into binpash:future Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants