Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run on push to main #68

Merged
merged 1 commit into from
Jan 16, 2024
Merged

run on push to main #68

merged 1 commit into from
Jan 16, 2024

Conversation

daler
Copy link
Member

@daler daler commented Jan 15, 2024

No description provided.

@bgruening bgruening merged commit b2e3432 into main Jan 16, 2024
4 checks passed
@bgruening bgruening deleted the test-new-build branch January 16, 2024 10:58
@bgruening
Copy link
Member

Thanks @daler! And @martin-g for the review!

@martin-g
Copy link
Contributor

The push to Quay.io failed with:

Error: trying to reuse blob sha256:174f5685490326fc0a1c0f5570b8663732189b327007e47ff13d2ca59673db02 at destination: checking whether a blob sha256:174f5685490326fc0a1c0f5570b8663732189b327007e47ff13d2ca59673db02 exists in ***/bioconda/bioconda-utils-build-env-cos7-x86_64: unauthorized: authentication required

https://github.com/bioconda/bioconda-containers/actions/runs/7540600440/job/20525545529

Could it be that the secrets are outdated ?

username: ${{ secrets.QUAY_BIOCONDA_USERNAME }}
password: ${{ secrets.QUAY_BIOCONDA_TOKEN }}

@martin-g
Copy link
Contributor

From the same actions log:

Combining image name "bioconda/bioconda-utils-build-env-cos7-x86_64" and registry "***" to form registry path "***/bioconda/bioconda-utils-build-env-cos7-x86_64"
Warning: "***/bioconda/bioconda-utils-build-env-cos7-x86_64" does not seem to be a valid registry path. The registry path should not contain more than 2 slashes. Refer to the Inputs section of the readme for naming image and registry.

This makes me this that ${{ secrets.QUAY_BIOCONDA_REPO }} is not just quay.io but something that contains a /, maybe quay.io/bioconda ?!

@daler
Copy link
Member Author

daler commented Jan 16, 2024

I should have marked it draft, sorry! This yaml is still trying to use the Release Please release trigger used over in bioconda-utils. That's where it gets the tags from. Not sure if that's the issue here.

I don't have time to continue but @martin-g if you want to take a stab at refactoring to match the other yamls in this repo (which use major/minor versioning) that will help.

@martin-g
Copy link
Contributor

Sure! I will see what has to be done!

martin-g added a commit to martin-g/bioconda-containers that referenced this pull request Jan 17, 2024
Use same versions as in the other Docker images:
- major -> 3
- minor -> 0

Suggested-at: bioconda#68 (comment)

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g mentioned this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants