Reusable workflow testing #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use same versions as in the other Docker images: - major -> 3 - minor -> 0 Suggested-at: #68 (comment) Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Install QEMU for all CPU architectures but amd64. At the moment this is just arm64 but now adding a new arch will not require changes to this step Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Split by whitespace Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Remove debug statements and commented out code Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Test quay push
martin-g
reviewed
Feb 5, 2024
.github/workflows/generic_build.yml
Outdated
| # ---------------------------------------------------------------------- | ||
|
|
||
| # Build each arch's image | ||
| for arch in $archs_and_images ; do |
There was a problem hiding this comment.
Currently only an AMD64 image is added to the manifest - https://pipelinesghubeus24.actions.githubusercontent.com/0YHXh0QGzpCiRgaqrcqmDx4aoYjcAOBDwhzeyyC598TlkSuHqS/_apis/pipelines/1/runs/345/signedlogcontent/2?urlExpires=2024-02-05T15%3A40%3A20.3157368Z&urlSigningMethod=HMACV1&urlSignature=hK6kHUewgqlYl8%2BGIobY20GzaihVEyRhvkhn2ZBPr00%3D.
I think this should be for arch in "${archs_and_images[@]}"; do to iterate over the strings in the Bash array.
|
Do you need any help with this ? |
|
@martin-g I just commented over in #74 (comment) to keep the info contained within that issue. |
|
Closing in favor of bioconda/bioconda-utils#953; see #74 for rationale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for working out the details of how reusable workflows for container building might work to address #64 and to make building {arm,amd}64 containers more straightforward -- and therefore more sustainable for community maintenance.