Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: MultiQC - Bump to v1.22 #47904

Merged
merged 1 commit into from
May 23, 2024
Merged

Update: MultiQC - Bump to v1.22 #47904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions recipes/multiqc/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{% set version = "1.21" %}
{% set version = "1.22" %}

package:
name: multiqc
version: {{ version }}

source:
url: https://github.com/MultiQC/MultiQC/archive/v{{ version }}.tar.gz
sha256: c0e4887598628567b8fb1539445cf7b34a7ac6a8db2e52e10cc42cfa8e2202e2
sha256: b4a7264e49481c56f11138a24083dca80bb107f5dbaef248806c11db69a373e3

build:
number: 0
Expand Down Expand Up @@ -44,8 +44,11 @@ requirements:
- requests
- rich >=10
- rich-click
- tqdm
- simplejson
- spectra >=0.0.10
- pydantic >=2.7.1
- typeguard

test:
# Python imports
Expand Down Expand Up @@ -76,8 +79,6 @@ extra:
# click requires a unicode locale when used with Python 3
# extended-base generates en_US.UTF-8 locale and sets LC_ALL, LANG properly
extended-base: true
Comment on lines 79 to 81
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that this is really needed now. Does anyone else have recent experience of bioconda packages using Click?

It would be nice to remove this and get smaller bioconda images. I also wonder if using a different image base could fix the Docker issues happening recently in GitPod: MultiQC/MultiQC#2283

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure either - should we just try ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using rich-click and usually that's enough (dont need tqdm, pydantic, typeguard)

skip-lints:
- uses_setuptools # uses pkg_resources
identifiers:
- biotools:multiqc
- doi:https://doi.org/10.1093/bioinformatics/btw354