Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl-text-roman #47942

Closed
wants to merge 7 commits into from
Closed

perl-text-roman #47942

wants to merge 7 commits into from

Conversation

Pombert-JF
Copy link
Contributor

I created a recipe for the Perl Text::Roman module available in cpan using the bioconda perl-text-glob recipe as template. It was not available in conda channels. I need this perl module for a conda recipe about a pipeline I developed recently to investigate genome collinearity (https://github.com/PombertLab/SYNY).

I tested the perl-text-roman recipe locally with conda build and it seems to work fine. It is my first time contributing to bioconda so hopefully I did not make any mistake.

Best regards,
JF


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@Pombert-JF
Copy link
Contributor Author

Pombert-JF commented May 18, 2024

I'm not sure how to fix the '##[error]No hosted parallelism has been purchased or granted.' issue or if I can. It seems attached to the https://dev.azure.com/bioconda/bioconda-recipes account.

@Pombert-JF Pombert-JF closed this May 19, 2024
@Pombert-JF Pombert-JF reopened this May 19, 2024
@martin-g
Copy link
Contributor

I'm not sure how to fix the '##[error]No hosted parallelism has been purchased or granted.' issue

See #41025

@Pombert-JF Pombert-JF closed this May 23, 2024
@Pombert-JF Pombert-JF reopened this May 23, 2024
recipes/perl-text-roman/meta.yaml Outdated Show resolved Hide resolved
- perl-module-build
run:
- perl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need some tests:

test:
  commands:
    - ???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the following test based on the other Perl modules in bioconda.

test:
  imports:
    - Text::Roman

recipes/perl-text-roman/meta.yaml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Pombert-JF Pombert-JF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the requested changes and it passed all the checks. Many thanks. - JF

- perl-module-build
run:
- perl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the following test based on the other Perl modules in bioconda.

test:
  imports:
    - Text::Roman

@bgruening
Copy link
Member

@Pombert-JF those general perl-packages should be included in conda-forge. Can you please do that instead? Thanks.

@Pombert-JF
Copy link
Contributor Author

ok will do that thanks.

@Pombert-JF Pombert-JF closed this May 24, 2024
@Pombert-JF Pombert-JF deleted the perl-text-roman branch May 24, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants