-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chopper for M3s #51754
Update chopper for M3s #51754
Conversation
This PR adds some changes to make this work on mac M3s, based on wdecoster/chopper#40
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
recipes/chopper/meta.yaml (2)
11-15
: Consider removing redundant skip condition
The skip: false # [not (linux-64 or osx)]
condition is redundant with the explicit platforms
list below it. The platforms list is a clearer way to specify supported platforms.
- skip: false # [not (linux-64 or osx)]
48-48
: Consider linking to more comprehensive documentation
The doc_url
currently points to the README. Consider creating and linking to more comprehensive documentation, especially given the new platform support.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/chopper/meta.yaml (2 hunks)
🔇 Additional comments (1)
recipes/chopper/meta.yaml (1)
Line range hint 35-37
: Verify the need for clang as a runtime dependency
The package includes clang
as a runtime dependency, which is unusual. Typically, clang is only needed during build time for Rust packages. Please verify if this is intentionally required at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/chopper/meta.yaml (1)
42-45
: Documentation and metadata additions look good.
The added URLs and notes provide valuable information about the package's capabilities and resources.
Consider expanding the notes to include specific version requirements or limitations, if any:
notes: |
- includes native support for Apple Silicon (M1/M2/M3) processors
+ includes native support for Apple Silicon (M1/M2/M3) processors since version X.X.X
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/chopper/meta.yaml (2 hunks)
🔇 Additional comments (2)
recipes/chopper/meta.yaml (2)
9-10
: Build configuration is well structured.
The use of run_exports
with appropriate pinning helps prevent API/ABI breakage, following best practices.
47-50
: Platform support changes look good.
The addition of ARM platforms (linux-aarch64 and osx-arm64) aligns with the PR objective of enabling M3 support.
Let's verify the build requirements are sufficient for ARM platforms:
@martin-g the test now failed, could you identify why? |
The Linux ARM64 build fails due to:
i.e. the minimap2 crate uses SSE intrinsics. I will remove the ARM64 platforms. |
This PR adds some changes to make this work on mac M3s, based on wdecoster/chopper#40
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.