Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chopper for M3s #51754

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Update chopper for M3s #51754

merged 4 commits into from
Oct 29, 2024

Conversation

wdecoster
Copy link
Contributor

This PR adds some changes to make this work on mac M3s, based on wdecoster/chopper#40


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

This PR adds some changes to make this work on mac M3s, based on wdecoster/chopper#40
Copy link
Contributor

coderabbitai bot commented Oct 29, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request modifies the meta.yaml file for the chopper package, updating the version number from 0.9.0 to 1 and changing the build number from 0 to 1. New fields are added under the about section, including dev_url, doc_url, and notes, which provide links to the development repository, documentation, and a note about native support for Apple Silicon processors. The existing fields in the about section remain unchanged.

Possibly related PRs

Suggested labels

osx-arm64


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f27565a and 546cd82.

📒 Files selected for processing (1)
  • recipes/chopper/meta.yaml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • recipes/chopper/meta.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
recipes/chopper/meta.yaml (2)

11-15: Consider removing redundant skip condition

The skip: false # [not (linux-64 or osx)] condition is redundant with the explicit platforms list below it. The platforms list is a clearer way to specify supported platforms.

-  skip: false # [not (linux-64 or osx)]

48-48: Consider linking to more comprehensive documentation

The doc_url currently points to the README. Consider creating and linking to more comprehensive documentation, especially given the new platform support.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f83e9c7 and 4c3ad1e.

📒 Files selected for processing (1)
  • recipes/chopper/meta.yaml (2 hunks)
🔇 Additional comments (1)
recipes/chopper/meta.yaml (1)

Line range hint 35-37: Verify the need for clang as a runtime dependency

The package includes clang as a runtime dependency, which is unusual. Typically, clang is only needed during build time for Rust packages. Please verify if this is intentionally required at runtime.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
recipes/chopper/meta.yaml (1)

42-45: Documentation and metadata additions look good.

The added URLs and notes provide valuable information about the package's capabilities and resources.

Consider expanding the notes to include specific version requirements or limitations, if any:

  notes: |
-    includes native support for Apple Silicon (M1/M2/M3) processors
+    includes native support for Apple Silicon (M1/M2/M3) processors since version X.X.X
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 4c3ad1e and f27565a.

📒 Files selected for processing (1)
  • recipes/chopper/meta.yaml (2 hunks)
🔇 Additional comments (2)
recipes/chopper/meta.yaml (2)

9-10: Build configuration is well structured.

The use of run_exports with appropriate pinning helps prevent API/ABI breakage, following best practices.


47-50: Platform support changes look good.

The addition of ARM platforms (linux-aarch64 and osx-arm64) aligns with the PR objective of enabling M3 support.

Let's verify the build requirements are sufficient for ARM platforms:

@wdecoster
Copy link
Contributor Author

@martin-g the test now failed, could you identify why?

@martin-g
Copy link
Contributor

The Linux ARM64 build fails due to:

 error[E0606]: casting `&*mut minimap2_sys::mm_idx_t` as `*const minimap2_sys::mm_idx_t` is invalid�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT)    --> /opt/conda/conda-bld/chopper_1730197518455/work/.cargo/registry/src/index.crates.io-6f17d22bba15001f/minimap2-0.1.20+minimap2.2.28/src/lib.rs:834:25�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT)     |�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT) 834 |                         self.idx.as_ref().unwrap() as *const mm_idx_t,�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT)     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT) �[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT) error[E0606]: casting `&*mut minimap2_sys::mm_idx_t` as `*const minimap2_sys::mm_idx_t` is invalid�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT)    --> /opt/conda/conda-bld/chopper_1730197518455/work/.cargo/registry/src/index.crates.io-6f17d22bba15001f/minimap2-0.1.20+minimap2.2.28/src/lib.rs:974:41�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT)     |�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT) 974 | ...                   &self.idx.unwrap() as *const mm_idx_t,�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT)     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT) �[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT) error[E0606]: casting `&*mut minimap2_sys::mm_idx_t` as `*const minimap2_sys::mm_idx_t` is invalid�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT)     --> /opt/conda/conda-bld/chopper_1730197518455/work/.cargo/registry/src/index.crates.io-6f17d22bba15001f/minimap2-0.1.20+minimap2.2.28/src/lib.rs:1021:41�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT)      |�[0m
10:28:15 �[32mBIOCONDA INFO�[0m (OUT) 1021 | ...                   &self.idx.unwrap() as *const mm_idx_t,�[0m

i.e. the minimap2 crate uses SSE intrinsics. I will remove the ARM64 platforms.

@bgruening bgruening merged commit 24494c4 into master Oct 29, 2024
6 checks passed
@bgruening bgruening deleted the patch_chopper_for_M3 branch October 29, 2024 14:51
@coderabbitai coderabbitai bot mentioned this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants