-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Saccharis #52722
Update Saccharis #52722
Conversation
… sha256 hash, and added --single-version-externally-managed --record=record.txt args to setup.py install as per bioconda test suite
adds chunk reducing size to database download streaming
# Conflicts: # recipes/saccharis/meta.yaml
increment to build 8
# Conflicts: # recipes/saccharis/meta.yaml
…into saccharis
increment to build 9
fix error on duplicate user ids in different files
increment to build 1
# Conflicts: # recipes/saccharis/meta.yaml
… on NCBI connection retry increment to build 2
# Conflicts: # recipes/saccharis/meta.yaml
@BiocondaBot please add label |
So to clarify, you have just updated the release tarball on your github repo and you're just changing the hash to match that new tarball? Wouldn't some kind of fix like this normally warrant a patch version bump? |
It was such a small fix and there's some other updates I'm working on that I had already been planning to release as "2.0.3" so I thought I would just replace the tarball. But from the user perspective this does fix a crash bug, which is severe, and there is no real reason for me to be attached to the specific version numbers and so I agree this should get a proper version bump. I have updated the version numbers, added a new release on github, and updated the meta.yaml file in accordance with the versioning scheme. |
Sorry @AlexSCFraser , didn't mean to make you do a new release. |
Update saccharis to fix crash bug on configuration command and reduce rate of delay increase on NCBI connection failures.
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.