Add needletail
#52723
Merged
Add needletail
#52723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbhall88 sorry for tagging you here, but I know you're working on better Rust documentation for Bioconda and we still don't have good recommendations for Maturin. Do you know what could be done here? Apparently, this approach of building a wheel and then installing it doesn't support cross-compilation. However, |
|
@apcamargo I don't have any Maturin experience unfortunately. I can try and have a read/play tomorrow. Maybe we could also ask @bioconda/rust and see if anyone else in that group has Maturin experience, or can point us at a repo that uses it. I think @luizirber might have some experience with Maturin via sourmash?? |
luizirber
requested changes
Dec 19, 2024
There was a problem hiding this comment.
We moved the sourmash recipe to the v1 format over in https://github.com/conda-forge/sourmash-minimal-feedstock/blob/5f7964f0f0a29b3bf6522a9989cd99c9b4ee3c6b/recipe/recipe.yaml, so some things will be different from here, but I think the only detail missing is cffi in the host and build sections (with comments for cross-compilation)
| - python # [build_platform != target_platform] | ||
| - cross-python_{{ target_platform }} # [build_platform != target_platform] | ||
| - crossenv # [build_platform != target_platform] | ||
| - maturin >=1,<2 # [build_platform != target_platform] |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| host: | ||
| - python | ||
| - pip | ||
| - maturin >=1,<2 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
wait, needletail doesn't use CFFI bindings, it uses pyo3, so maturin is misconfigured... |
|
Added a patch to fix maturin config, might be good to upstream it for next release |
luizirber
approved these changes
Dec 19, 2024
|
Amazing @luizirber. Let's see if adding in ARM builds works too 🤞 |
|
@apcamargo I might suggest checking the artifacts to make sure it all works as you expect. When you're happy it does what you expect, feel free to merge. |
|
@BiocondaBot please fetch artifacts |
|
Package(s) built are ready for inspection:
Docker image(s) built:
|
The Linux-aarch64 build looks good to me! |
|
I tested out the MAC ARM one and it was good too. Ima merge this. Great work team |
|
This was quick! Thanks @mbhall88 @luizirber @martin-g!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
needletailPython library.Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.