-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix image artifact regex to match GitHub Actions filename #1013
Conversation
WalkthroughThe pull request introduces a modification to the regular expression used for matching image names in the Aside from this update to the regular expression, there are no other changes to the logic, error handling, or control flow within the file. The structure and functionality of the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- bioconda_utils/artifacts.py (1 hunks)
🔇 Additional comments (1)
bioconda_utils/artifacts.py (1)
21-21
: Verify GitHub Actions integration end-to-end.While the regex change is correct, please ensure:
- The GitHub Actions workflow correctly handles the new artifact format
- The artifact download and processing flow in
get_gha_artifacts()
works with the modified namesLet's check the GitHub Actions workflow files and artifact handling:
✅ Verification successful
GitHub Actions integration appears to be unaffected by the regex change
The regex change in
IMAGE_RE
is safe because:
- The GitHub Actions workflow (
changevisibility.yml
) only uploads log files with patternbiocontainers-*.txt
, not container images- The
get_gha_artifacts()
function inartifacts.py
handles artifact downloads generically without relying on the modified regex pattern- The
IMAGE_RE
pattern is only used for parsing artifact names after they are downloaded, not for the GitHub Actions upload/download process itselfThe integration remains intact as the artifact handling flow operates independently of the image name parsing logic.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify GitHub Actions workflow configuration and artifact handling # Check workflow files for artifact upload configuration echo "Checking workflow configurations:" fd -e yml -e yaml . .github/workflows/ --exec grep -l "actions/upload-artifact" # Look for any existing artifact handling code echo "Checking artifact handling patterns:" rg -l "actions/upload-artifact|actions/download-artifact" .Length of output: 340
Script:
#!/bin/bash # Let's examine the workflow file content and artifact handling code more thoroughly # Check the content of the workflow file echo "=== Workflow file content ===" cat .github/workflows/changevisibility.yml # Look for artifact-related code in the Python files echo -e "\n=== Artifact handling code ===" rg -A 10 "get_gha_artifacts" . # Check for any artifact name patterns or related constants echo -e "\n=== Artifact name patterns ===" rg "\.tar\.gz" .Length of output: 11453
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urrgs, nice find!
🤖 I have created a release \*beep\* \*boop\* --- ### [3.4.1](https://www.github.com/bioconda/bioconda-utils/compare/v3.4.0...v3.4.1) (2024-10-28) ### Bug Fixes * fix image artifact regex to match GitHub Actions filename ([#1013](https://www.github.com/bioconda/bioconda-utils/issues/1013)) ([c1adeea](https://www.github.com/bioconda/bioconda-utils/commit/c1adeeac7125a1483cd3ab57c2dd034a0f6978e3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GitHub Actions doesn't allow artifact files to contain
:
, so it is replaced with---
. Update this artifact finding code to match that pattern.