refactor: Pylint alerts corrections as part of an intervention experiment 298 #1022
Conversation
Removed unnecessary parenthesis
Method do_setup had 15 branches and function get_versions had 13 branches while Pylint recommends to have no more than 12.
The function build checks the value of "pkg_dir is None" in a if statement and assigns it to the variable use_host_conda_bld (line 469).I assigned the expression directly to the variable, removing the unneeded if and simplifying the code.
Removed unnecessary pass
Removed unnecessary parenthesis
The function build had 66 statements and the function build_recipes had 86, while Pylint recommends having no more than 50. Functions were structured so I extracted methods to handle specific logics, simplifying the code.
In the class Recipe the method replace had 13 branches and the static method _rewrite_selector_block had 14, while Pylint recommends having no more than 12. I extracted small methods to reduce the complexity.
The function "check" had 14 branches , while Pylint recommends having no more than 12. I extracted a method to handle the metas.
The function run had 13 branches and, while Pylint recommends having no more than 12. I extracted _handle_process to reduce the complexity.
The method apply of the class CreatePullRequest had 14 branches and, while Pylint recommends having no more than 12. I extracted _handle_open_PRs to reduce the complexity.
evidencebp
changed the title
|
|
@jmarshall , I'll exclude versioneer.py As for the too-many interventions, in this PR the code is not very-much-too-many. |
|
It's not my decision. If it was, I would have just closed WONTFIX your initial issue. Your experiment may be interesting to you, but it's mostly a waste of time for the projects you're experimenting on. |
Makes the interventions describe in intervention issue.
The experiment is described here.
Each intervention was done in a dedicated commit with a message explaining it.