Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update pinning 2024-05 #991

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

mbargull
Copy link
Member

@mbargull mbargull commented May 29, 2024

Amongst others, this includes:

  • Update default minimum system targets to
    • glibc 2.17/CentOS 7 ( *needs recipes to include new - {{ stdlib("c") }} dep in requirements/build)
    • macOS 10.13
  • Python 3.11 and 3.12

closes gh-938, gh-988

@mbargull mbargull requested a review from aliciaaevans May 29, 2024 15:37
@mbargull mbargull changed the title Update pinning 2024-05 feat: Update pinning 2024-05 May 29, 2024
@mbargull mbargull marked this pull request as draft May 29, 2024 16:05
@aliciaaevans
Copy link
Contributor

Here's the conda-forge announcement for information of anyone wondering about the stdlib stuff: https://conda-forge.org/news/2024/03/24/stdlib-migration/

@aliciaaevans
Copy link
Contributor

@mbargull is this one dependent on #992?

mbargull added 7 commits June 3, 2024 08:51
These stdlib_c entries can be used with newer conda-build versions in
recipes like so:

  requirements:
    build:
      - {{ stdlib("c") }}
      - {{ compiler("c") }}

and allow us to be explicit about our libc/system dependencies.
I.e., we could then avoid MACOSX_DEPLOYMENT_TARGET/sysroot_linux* dances

Signed-off-by: Marcel Bargull <[email protected]>
Those are covered by "run_exports" nowadays.

Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Just for good measure.

Signed-off-by: Marcel Bargull <[email protected]>
@mbargull mbargull force-pushed the update-pinning-2024-05 branch from c6b2412 to e765095 Compare June 3, 2024 06:53
@mbargull
Copy link
Member Author

mbargull commented Jun 3, 2024

Sorry, wanted to be available Friday but got knocked out with headaches and stuff :/ .

@mbargull is this one dependent on #992?

Strictly speaking, no.
But there were some improvements in those updates which should make things work more smoothly going forward.

Over the weekend, I smoothed out some more rough edges (see bioconda/bioconda-common#54) and rebuilt our container images, so this should be ready to go.

One caveat: I mentioned before that we are ready to put out .conda packages -- and we are in principle and I already uploaded one such package: https://anaconda.org/bioconda/bioconda-utils/files/modal/info/665ce27336ee7a8e2befd3c1 .
But it turns out those packages aren't added to the CDN-backed channel for bioconda, so I backed out of that change until conda/infrastructure#950 is resolved.

@mbargull mbargull marked this pull request as ready for review June 3, 2024 07:39
@mbargull
Copy link
Member Author

mbargull commented Jun 3, 2024

* Update default minimum system targets to
  
  * `glibc 2.17`/CentOS 7

to clarify: this only applies for recipes for which we add the - {{ stdlib("c") }} part.

@aliciaaevans aliciaaevans merged commit d48d6e4 into bioconda:master Jun 3, 2024
11 checks passed
aliciaaevans pushed a commit that referenced this pull request Jun 3, 2024
🤖 I have created a release \*beep\* \*boop\*
---
##
[3.3.0](https://www.github.com/bioconda/bioconda-utils/compare/v3.2.0...v3.3.0)
(2024-06-03)


### Features

* Update pinning 2024-05
([#991](https://www.github.com/bioconda/bioconda-utils/issues/991))
([d48d6e4](https://www.github.com/bioconda/bioconda-utils/commit/d48d6e4f09046bf4142a63805e1366f655cefd71))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants