Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency on natsort #953

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Removed dependency on natsort #953

merged 1 commit into from
Apr 10, 2024

Conversation

qiyunzhu
Copy link
Contributor

The package natsort is listed as a dependency but it is actually never used. Instead, BIOM has a built-in natsort function. Therefore this dependency can be removed. See:

scikit-bio/scikit-bio#2007

@wasade
Copy link
Member

wasade commented Apr 10, 2024

Am +1 assuming all green

@qiyunzhu
Copy link
Contributor Author

@wasade All greened.

@wasade wasade merged commit 50b6908 into biocore:master Apr 10, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants