Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SBI Kit Article Code #593

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Add SBI Kit Article Code #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bffcc8
Add SBI kit article code
cassidysymons Jan 7, 2025
200586c
Unit tests
cassidysymons Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions microsetta_private_api/admin/tests/test_admin_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,7 +1207,7 @@ def test_get_daklapack_articles_not_retired(self):
with Transaction() as t:
admin_repo = AdminRepo(t)
articles = admin_repo.get_daklapack_articles()
self.assertEqual(8, len(articles))
self.assertEqual(9, len(articles))
first_article = articles[0]
first_article.pop("dak_article_id")
self.assertEqual(FIRST_LIVE_DAK_ARTICLE, first_article)
Expand All @@ -1216,7 +1216,7 @@ def test_get_daklapack_articles_all(self):
with Transaction() as t:
admin_repo = AdminRepo(t)
articles = admin_repo.get_daklapack_articles(include_retired=True)
self.assertEqual(24, len(articles))
self.assertEqual(25, len(articles))
first_article = articles[0]
first_article.pop("dak_article_id")
self.assertEqual(FIRST_DAK_ARTICLE, first_article)
Expand Down
2 changes: 2 additions & 0 deletions microsetta_private_api/db/patches/0143.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-- Add article code for Skin Biome Initiative kit
INSERT INTO barcodes.daklapack_article (dak_article_code, short_description, detailed_description) VALUES ('3510007E', 'SBI 1matrix tube', 'SBI 1 matrix tube, American English');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the kits physically differ from TMI with e.g., different branding or instructions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the printed instructions are different and the kit contains additional physical assets for the sample collection procedure (a template and gloves).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Could you send links to those assets by email?