Skin Surveys #596
Open
Skin Surveys #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into csymons_skin_surveys
AmandaBirmingham
approved these changes
Jan 10, 2025
| @@ -702,9 +704,9 @@ def test_bobo_takes_all_local_surveys(self): | |||
| SurveyTemplateRepo.ALLERGIES_ID, | |||
| SurveyTemplateRepo.DIET_ID, | |||
| SurveyTemplateRepo.DETAILED_DIET_ID, | |||
| SurveyTemplateRepo.MIGRAINE_ID, | |||
| SurveyTemplateRepo.SURFERS_ID, | |||
| SurveyTemplateRepo.COVID19_ID): | |||
There was a problem hiding this comment.
Curious: why were these surveys deleted?
There was a problem hiding this comment.
The surveys were removed from the actual user flow during the relaunch process, but not from this integration test. The fact that the test wasn't failing, even though we retired the surveys, is something that I'll need to investigate and I've created a GitHub issue reflecting that. Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new surveys:
And all of the constituent questions, responses, and information for those surveys. In addition, it adds a few new questions to other surveys and moves a couple of questions between surveys.
Corresponding microsetta-interface PR is biocore/microsetta-interface#329