Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ImageJ.JS as the front-end for model test run #364

Merged
merged 36 commits into from
Dec 5, 2023

Conversation

Nanguage
Copy link
Contributor

@Nanguage Nanguage commented Nov 8, 2023

image

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for bioimage ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6ced9bb
🔍 Latest deploy log https://app.netlify.com/sites/bioimage/deploys/656efdc9d72e0c0008557221
😎 Deploy Preview https://deploy-preview-364--bioimage.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nanguage
Copy link
Contributor Author

Nanguage commented Nov 8, 2023

TODO List:

  • Convert ImJoy plugin to a Vue component
  • Re shape the image to satisfy the spec
  • Change sample input to test-input(.npy file) by default
  • Add the code to wait imjoy start before imagej.js start
  • Fix the bug caused by image byte endian
  • Check if the item is a model or not
  • Check if the model is exist or not from: the manifest
  • Check if the model is an img-to-img model, if it is, will show result using a table.
  • Create padder to allow user to input any xyz size image
  • Tiler for chunking the big images
  • Advance setting for set the tile size, input axes ...

@Nanguage Nanguage changed the title Using Image J as the front-end for TestRun Using ImageJ as the front-end for model test run Nov 8, 2023
@Nanguage Nanguage changed the title Using ImageJ as the front-end for model test run Using ImageJ.JS as the front-end for model test run Nov 9, 2023
src/utils.js Outdated Show resolved Hide resolved
@Nanguage
Copy link
Contributor Author

Nanguage commented Nov 21, 2023

ezgif com-optimize

Now, by adding padding, it is possible to input images of any size. However, there are some models whose shape meets the spec but cannot work, such as the affable-shark model. @oeway

Details:

image

I think the shape of input conforms to the definition in the spec:

image

The rdf of shark model:

image

@oeway
Copy link
Collaborator

oeway commented Nov 21, 2023

Now, by adding padding, it is possible to input images of any size. However, there are some models whose shape meets the spec but cannot work, such as the affable-shark model. @oeway

Great! Thanks!
Will need to fix from the server side. Will get back to you once I fixed it.

Edit: Please also rebase from the main branch to allow merging the PR.

@oeway oeway mentioned this pull request Nov 21, 2023
src/components/TestRun.vue Outdated Show resolved Hide resolved
@Nanguage
Copy link
Contributor Author

Nanguage commented Nov 25, 2023

How to display the results of non-img-to-img models, such as the HPA classification model. One idea is to display it as a table. I'm not sure if ImageJ.JS can open a window that can embed HTML elements. Or we simply display the output array as an image. @oeway

@jmetz
Copy link
Collaborator

jmetz commented Nov 25, 2023

ImageJ should have a ResultsTable that tabular data can be displayed in. That would be very familiar for ImageJ users

@oeway
Copy link
Collaborator

oeway commented Nov 25, 2023

ImageJ should have a ResultsTable that tabular data can be displayed in. That would be very familiar for ImageJ users

Good suggestion! Yes, we should use the result table, maybe via a imagej macro call.

Reference: https://forum.image.sc/t/creating-custom-tables-in-imagej/33100/2

@Nanguage
Copy link
Contributor Author

Nanguage commented Dec 5, 2023

Show classification result as a table

bioimageio-classification-table

Advance option allow user set the tile size and overlap

ezgif com-optimize

Could you give it a try? @oeway If it's ok, I think it's time for merge.

Copy link
Collaborator

@oeway oeway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oeway oeway merged commit d405121 into bioimage-io:main Dec 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants