Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/macos-ci-failure #14

Merged
merged 1 commit into from
Dec 18, 2024
Merged

bugfix/macos-ci-failure #14

merged 1 commit into from
Dec 18, 2024

Conversation

BrianWhitneyAI
Copy link
Contributor

Description

Resolves #10

Copy link

@toloudis toloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome if this fixes it - should imageio (or bioio-imageio?) automatically install ffmpeg or is it a known thing that users have to install it themselves?

@BrianWhitneyAI
Copy link
Contributor Author

Awesome if this fixes it - should imageio (or bioio-imageio?) automatically install ffmpeg or is it a known thing that users have to install it themselves?

The direct error that users see is RuntimeError: No ffmpeg exe could be found. Install ffmpeg on your system, or set the IMAGEIO_FFMPEG_EXE environment variable. I am ok with passing this to users instead of trying to do it for them since there is some difference between OS. So I think that imageio has already made a decision here. I think I slightly lean towards bioio-imageio reflecting imageios choice

Copy link

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh this makes sense. I think we should add a warning or raise an exception that explains the missing FFMPEG library

@BrianWhitneyAI
Copy link
Contributor Author

@evamaxfield I think the raised error is already fairly descriptive RuntimeError: No ffmpeg exe could be found. Install ffmpeg on your system, or set the IMAGEIO_FFMPEG_EXE environment variable. Im going to merge this for now. Feel free to open a new issue if you think it needs more.

@BrianWhitneyAI BrianWhitneyAI merged commit 3a9a4e7 into main Dec 18, 2024
13 checks passed
@BrianWhitneyAI BrianWhitneyAI deleted the bugfix/macos-ci-failure branch December 18, 2024 23:47
@evamaxfield
Copy link

@evamaxfield I think the raised error is already fairly descriptive RuntimeError: No ffmpeg exe could be found. Install ffmpeg on your system, or set the IMAGEIO_FFMPEG_EXE environment variable. Im going to merge this for now. Feel free to open a new issue if you think it needs more.

Ahhhh understood. Totally agree, misread prior messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing for MacOS
4 participants