-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename pixel size property to match bioio-base #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests pass and seems fine with me! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Is performance ok if you change scene, get pixel size, change scene, get pixel size, etc? |
I did some extremely basic In case indexing matters, I switched between scenes that were not adjacent (e.g., 3 to 78 to 24). With the changes applied to bioio-lif and bioio-base, the first time a scene was accessed it took 1-30 secs to change to that new scene and get/print pixel size. When the code was re-run with the same scenes, it took less than a second to switch and get/print pixel size. As a reference, for both versions of the code (with and w/o changes) it took me 5-18 minutes to run Worth noting that I'm testing this on vpn to access Vast files, so my times may not accurately reflect running on local files. |
We might just want a new issue ticket to see if we can/should make this faster. I don't have a good sense of how important LIF files will be moving forward within AICS. |
Link to Relevant Issue
This pull request resolves #14 : The
physical_pixel_sizes
property was not being updated on scene changes.Requires the change in bioio-devs/bioio-base#27 for the property to actually reset
Description of Changes
Rename existing
_px_sizes
property to match_physical_pixel_sizes
frombioio-base
. This will make it so that when the property is reset from the base class (i.e., when the scene changes), pixel sizes will be recalculated in the LIF reader.Testing
Verified that the existing tests still pass. Have not added a new unit test yet, but am open to doing so if needed.
Tested manually by reproducing the issue, as follows: