Add resolution level to data access #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanLeRoy
requested review from
toloudis,
hughes036,
evamaxfield,
yrkim98,
tyler-foster and
BrianWhitneyAI
|
CI won't pass until this other PR in bioio-base is merged and released bioio-devs/bioio-base#10 |
toloudis
reviewed
Dec 5, 2023
bioio_ome_zarr/reader.py
Outdated
| def _read_delayed(self) -> xr.DataArray: | ||
| return self._xarr_format(delayed=True) | ||
|
|
||
| def _read_immediate(self) -> xr.DataArray: | ||
| return self._xarr_format(delayed=False) | ||
|
|
||
| def _xarr_format(self, delayed: bool) -> xr.DataArray: | ||
| image_data = self._zarr.load(str(self.current_scene_index)) | ||
| data_path = self._zarr.root_attrs["multiscales"][self.current_scene_index]["datasets"][self.current_resolution_level]["path"] |
There was a problem hiding this comment.
Nit: maybe check that the level is valid before indexing into datasets here?
There was a problem hiding this comment.
Hmm do you think that is necessary with set_current_resolution_level() checking to see if it is valid at set time?
evamaxfield
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #7
Description of Changes
This adds support for getting and setting resolution levels
Testing
Tested successfully locally with changes from the required partner PR here