feat(lsp): add codeActionKinds #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did you test this change? Please fill the |
rchl
reviewed
Aug 28, 2024
ematipico
reviewed
Aug 28, 2024
Done |
ematipico
approved these changes
Aug 29, 2024
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on this answer we need to provide codeactions to make sure that the saved call is valid
microsoft/language-server-protocol#1629 (comment)
fix: #3339
Same as eslint lsp
https://github.com/microsoft/vscode-eslint/blob/main/server/src/eslintServer.ts#L224
Test Plan
cargo test --package biome_lsp --test server -- server_capabilities_fix_all_code_action_kinds --exact --show-output
cargo test --package biome_lsp --test server -- server_capabilities_default_code_action_kinds --exact --show-output