Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ja): translate gritql page #1615

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

mehm8128
Copy link
Contributor

Summary

@mehm8128 mehm8128 requested a review from a team as a code owner December 31, 2024 01:57
Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit bc2f93a
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/677396d50a013b00089f5209
😎 Deploy Preview https://deploy-preview-1615--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

```

このパターンは、文字列 `'Hello, world!'` が渡された全ての `console.log()` の呼び出しに一致します。
ただし、GridQLは _構造的_ マッチングを行うため、フォーマットの詳細には関心がありません。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

textlint says we prefer to use「format」 to 「フォーマット」, but I think it is not proper for this sentence. Is there any idea?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think we should use リント and フォーマット instead of alphabet in overall now. (Initially I thought that リント is a bit awkward, so I decided to use lint and format as alphabet because they are also technical words.)

Could you fix it to pass textlint ci for now? I will adjust everything later.

Copy link
Contributor Author

@mehm8128 mehm8128 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, thank you!
I fixed temporarily it to be "format"🙆‍♂️

Copy link
Member

@unvalley unvalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT if resolved the comment

@unvalley unvalley changed the title docs: translate gritql page to ja docs(ja): translate gritql page Dec 31, 2024
@unvalley unvalley merged commit 4dacbb4 into biomejs:main Dec 31, 2024
9 checks passed
@unvalley
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants