Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce the configure-biome guide #811

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Jul 18, 2024

Summary

This PR renames How Biome works into Configure Biome.
I tried to improve the introduction of the Configuration file by talking about its structure.
We also point to the configuration reference for users looking for that.

I introduced a new section Ignore files that is the old include and ignore explained, but hopefully improved.
I first wanted separate this section into a dedicated guide.
However, I am no longer convinced it is a valuable change.
Also, I turn the Protected files section into a note in Ignore files.

I merged the two sections about the extends field into Share a configuration file.

I removed duplicated docs in the formatter/linter intro by pointing to the Ignore files section of the new guide.

In the future, I think we could introduce a new section for explaining our overrides field.

@Conaclos Conaclos requested a review from a team as a code owner July 18, 2024 15:08
Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit e1a6188
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/669bc162e431dc00088d405d
😎 Deploy Preview https://deploy-preview-811--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nhedger
Copy link
Member

nhedger commented Jul 18, 2024

I'm wondering if the title shouldn't be "Configuring Biome" instead to be aligned with other section titles such as "Getting started".

@ematipico
Copy link
Member

Looking at Astro: https://docs.astro.build/en/install-and-setup/

They use "Getting started", but the rest of the guides don't use the "ing" form. For example, it is "Migrate to Astro" and not "Migrating to Astro"

@Conaclos
Copy link
Member Author

I have no particular preferences. I was also hesitating between Ignoring files and Ignore file. Maybe we should always use the infinitive form, but for Getting Started because this carries an action?

@Conaclos Conaclos requested review from a team July 18, 2024 16:54
@nhedger
Copy link
Member

nhedger commented Jul 18, 2024

No strong feelings either. It just came to mind

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! I added few nits, but overall I like the new change! ❤️

src/content/docs/guides/configure-biome.mdx Outdated Show resolved Hide resolved
src/content/docs/guides/configure-biome.mdx Outdated Show resolved Hide resolved
src/content/docs/guides/configure-biome.mdx Outdated Show resolved Hide resolved
src/content/docs/guides/configure-biome.mdx Outdated Show resolved Hide resolved
Comment on lines 199 to 200
while `include` is only tested on regular files.
This means that if you want to prevent Biome from traversing a folder,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is true? I used include for folders, and it worked

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from the old docs. Maybe it is badly phrased. It means to say that include doesn't prevent Biome of traversing a folder that is not covered by include.
For example, if include contains only src, Biome will still visit test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed :)

src/content/docs/guides/configure-biome.mdx Outdated Show resolved Hide resolved
src/content/docs/guides/configure-biome.mdx Outdated Show resolved Hide resolved
@Conaclos Conaclos force-pushed the conaclos/configure-biome-guide branch 3 times, most recently from 31ba50d to e1a6188 Compare July 20, 2024 13:53
@arendjr
Copy link
Contributor

arendjr commented Jul 21, 2024

Regarding title verbs, I would use the -ing forms. It appears to be the most common choice, but style guides may differ of course. “Getting Started” is the most common example, and it feels less like a command than the imperative form “Get Started”. To me, “Configure Biome” feels like an action that should be taken, like a call-to-action button. But the content of the chapter is a guide on “configuring Biome”.

Found a good discussion on the topic also:

https://writing.stackexchange.com/questions/1545/verb-tense-for-technical-document-titles

I think the strongest argument I could find for using the imperative form (as is done currently in this PR) is that these forms of the verbs might be easier to recognize for non-English speakers. I think the strongest argument for continuous form (apart from historical convention) is that it is easiest to do consistently, since people note various examples where imperative form just feels awkward, so they still end up using “Getting Started” or the example of “Configuring Kubernetes”, despite using imperative form elsewhere).

Anyway, just food for thought :)

@Conaclos
Copy link
Member Author

I am going to merge the PR. Please feel free to open new PRs to update translations.

@Conaclos Conaclos merged commit a5fed61 into main Jul 22, 2024
7 checks passed
@Conaclos Conaclos deleted the conaclos/configure-biome-guide branch July 22, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants