[#31] iOS: downloadFile() - fix: progress callback should be called n…

…o matter whether there is begin callback set or not
birdofpreyru · Mar 26, 2024 · 7409907 · 7409907
1 parent 1e75477
commit 7409907
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/ios/Downloader.mm b/ios/Downloader.mm
@@ -75,10 +75,14 @@ - (NSString *)downloadFile:(RNFSDownloadParams*)params
 - (void)URLSession:(NSURLSession *)session downloadTask:(NSURLSessionDownloadTask *)downloadTask didWriteData:(int64_t)bytesWritten totalBytesWritten:(int64_t)totalBytesWritten totalBytesExpectedToWrite:(int64_t)totalBytesExpectedToWrite
 {
   NSHTTPURLResponse *httpResponse = (NSHTTPURLResponse *)downloadTask.response;
-  if (_params.beginCallback && !_statusCode) {
+
+  if (!_statusCode) {
     _statusCode = [NSNumber numberWithLong:httpResponse.statusCode];
     _contentLength = [NSNumber numberWithLong:httpResponse.expectedContentLength];
-    return _params.beginCallback(_statusCode, _contentLength, httpResponse.allHeaderFields);
+
+    if (_params.beginCallback) {
+      return _params.beginCallback(_statusCode, _contentLength, httpResponse.allHeaderFields);
+    }
   }
 
   if (_params.progressCallback && [_statusCode isEqualToNumber:[NSNumber numberWithInt:200]]) {