Skip to content

Commit

Permalink
Merge pull request media-kit#521 from alexmercerind/main
Browse files Browse the repository at this point in the history
fix(video_player_media_kit): do not acquire wakelock by default
  • Loading branch information
alexmercerind authored Oct 6, 2023
2 parents fcb4aae + 25c99a1 commit b4a8516
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
4 changes: 4 additions & 0 deletions video_player_media_kit/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.0.2

- fix: do not acquire wakelock by default

## 1.0.1

- fix: possible `Duration.zero` duration after `VideoEventType.initialized`
Expand Down
2 changes: 1 addition & 1 deletion video_player_media_kit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ package:video_player_media_kit allows [package:video_player](https://pub.dev/pac

```yaml
dependencies:
video_player_media_kit: ^1.0.0
video_player_media_kit: ^1.0.2

# NOTE:
# It is not necessary to select all.
Expand Down
5 changes: 4 additions & 1 deletion video_player_media_kit/lib/src/media_kit_video_player.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ import 'package:media_kit/media_kit.dart';
import 'package:media_kit_video/media_kit_video.dart';
import 'package:video_player_platform_interface/video_player_platform_interface.dart';

// https://github.com/dart-lang/linter/issues/1381
// ignore_for_file: close_sinks

/// package:media_kit implementation of [VideoPlayerPlatform].
///
/// References:
Expand Down Expand Up @@ -173,7 +176,7 @@ class MediaKitVideoPlayer extends VideoPlayerPlatform {
return Video(
key: ValueKey(_videoControllers[textureId]!),
controller: _videoControllers[textureId]!,
wakelock: true,
wakelock: false,
controls: NoVideoControls,
fill: const Color(0x00000000),
pauseUponEnteringBackgroundMode: false,
Expand Down
2 changes: 1 addition & 1 deletion video_player_media_kit/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_media_kit
description: package:video_player support for all platforms, based on package:media_kit.
homepage: https://github.com/media-kit/media-kit
repository: https://github.com/media-kit/media-kit
version: 1.0.1
version: 1.0.2
topics:
- video
- video-player
Expand Down

0 comments on commit b4a8516

Please sign in to comment.