nl_l3: fix nnhs handling a bit #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like we do when adding a route, ignore routes with no nexthops. Signed-off-by: Jonas Gorski <[email protected]>
We already rejected routes with nnhs == 0 earlier, so nnhs cannot be 0 at this stage. Instead, we have only two options, nnhs == 1 (single nexthop or on-link route), or nnhs > 1 (ecmp route). So convert the switch to a if-else and make the 0 for on-link and routes with unresolved neighbor explicit. Signed-off-by: Jonas Gorski <[email protected]>
We used the number of total nexthops for determining ecmp routes on creation, so we need to do the same on deletion. Signed-off-by: Jonas Gorski <[email protected]>
|
Note that nnhs just means number of nexthop objects, but a nexthop object may just reference a device for directly connected routes, and not necessarily gateways with IPs. Technically it would be possible to have ECMP routes with multiple on-link device nexthops, but 0 gateways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few issues around number of nexthops handling:
nnhs= 0) on add, but don't do so in removal (though I'm not convinced this is an actual thing that can happen)nnhs= 0 means no reachable(?) nexthop yet, but we already rejected routes withnnhs= 0 earlier, so this can't happen! Instead, check ifl3_interfacesis emptyl3_interfacesto determine if this is a ECMP route, but usennhsinstead