Settings page #199
Merged
Settings page #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has to be in sync with bisq2 PR @ bisq-network/bisq2#3188 |
… animation); TextField updated to handle decimals
rodvar
force-pushed
the
feature/settings_xclient
branch
from
e21922d to
4b842fa
Compare
|
rebased to latest main changes |
rodvar
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
Great @nostrbuddha
ACK (all 3 apps)
The language settings only will apply to that very seem settings screen, we can leave the generalized application for #150 . Hopefully. we'll make it before the MVP release, otherwise we can decide either to do it in full and delay or hide the language settings cause it would be confusing for the user that its there but language doesn't actually change.
| @@ -54,6 +56,7 @@ fun TopBar( | |||
| val tabNavController: NavHostController = presenter.getRootTabNavController() | |||
|
|
|||
| val interactionEnabled = presenter.isInteractive.collectAsState().value | |||
| val showAnimation = presenter.showAnimation.collectAsState().value | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #148