Backup, restore and create a new onion address via GUI #3044

freimair · 2019-08-01T11:39:46Z

This PR adds features that allow the user to

backup her current onion address,
restore a previously onion address backup
and even create a completely new onion address

all from within the GUI.

How do you make sure that there are no more open offers or even ongoing trades before you import/renew the address?
I don't. I have reworked the P2P backend so that a single client can have multiple hidden services up and running at any time. If the user renews/imports an onion address, a new hidden service is started. Hidden services are only removed once no more open offers or ongoing trades are there (checked for after every completed trade).

All during runtime?
No. A restart is required for the import and renew features.

Contains DE translations as well.

Here are some impressions:

Expected behaviour (for testers)

after renew/import onion address and an application restart, there should be one more hidden service alive (except when you import an address that you already had)
the hidden services will only be removed when no more trades and offers use an address. The decision which hidden service to remove is made when a trade completes (successful or not). If an address is not used anymore it is marked for removal and will not show up after an application restart.

closes #1055, closes #1056, subsequently closes #909 and does take care of a lot of preparation work for #2873.

core/src/main/java/bisq/core/trade/TradeManager.java

ManfredKarrer · 2019-08-14T18:44:51Z

If I make a backup of first HS and later restore that I have 3 HS where first and third are the same but have diff. dir names (fist is '0'). Leads to a timeout then... I think very first HS should also use timestamp as directory name. And seems handling of the original in case of restore is not correct.

ManfredKarrer · 2019-08-14T18:46:43Z

On OSX there is a .DS_Store file and caused an exception:
Aug-14 20:39:07.081 [JavaFX Application Thread] ERROR b.n.p2p.network.TorNetworkNode: Hidden service creation failed: java.io.IOException: Not a directory

ManfredKarrer

NACK

core/src/main/java/bisq/core/offer/OpenOfferManager.java

core/src/main/java/bisq/core/trade/TradeManager.java

desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.java

p2p/src/main/java/bisq/network/p2p/network/TorMode.java

p2p/src/main/java/bisq/network/p2p/network/TorNetworkNode.java

desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.java

freimair · 2019-08-14T18:54:09Z

If I make a backup of first HS and later restore that I have 3 HS where first and third are the same but have diff. dir names (fist is '0'). Leads to a timeout then...

is fixed in b4818d8

On OSX there is a .DS_Store file and caused an exception:

that is a bug. onto it...

ripcurlx · 2019-08-20T09:38:55Z

@freimair The build of your last commit failed on travis.

freimair · 2019-08-20T10:51:02Z

@ripcurlx yes I know and I have not figured out why suddenly, the desktop app tests start to fail. I am on to adding tests and get to the ground of that.

Update: Travis tests the merge (that is what surprised me). Recently, the test failing was introduced in master -> that is why it only recently showed up. The code works fine but the test fails as soon as something concerned about the TradeManager is at stake. Looking into resolving that circular dependency...

freimair · 2019-08-26T10:12:18Z

do you want me to change something?

ripcurlx · 2019-08-27T12:20:40Z

do you want me to change something?

No, I'll review the PR asap.

ManfredKarrer · 2019-08-27T17:42:36Z

@freimair Can you add the code part for correctly filtering the users node address I sent you in the patch? It is same code as used in arbitration and it maked the list containing only the correct addresses even if wrong addressed would not have any effect in your use case.

ripcurlx · 2019-09-02T09:29:47Z

@freimair Can you add the code part for correctly filtering the users node address I sent you in the patch? It is same code as used in arbitration and it maked the list containing only the correct addresses even if wrong addressed would not have any effect in your use case.

@ManfredKarrer Is there something still open after the last commit from @freimair?

ManfredKarrer · 2019-09-02T10:36:43Z

I don't have time for reviewing again and testing. Also I think @freimair did not implemented the suggestions I made yet. Maybe better to keep it for later as it carries high risk.

battleofwizards · 2019-09-06T09:59:26Z

Sorry for being very late to the party :( This is very loosely related to the PR but maybe will be helpful for the future.

IMO all secret keys should be derived from the Bitcoin seed. This includes the private key behind the onion address (or many of them if we want to support that).

This would entirely mitigate the need for multiple separate backups we now expect from the user. It would also make Bisq inline with what Bitcoin users expect from wallets software.

To large extent the standards for this are ready as BIP-39 (+family) and SLIP-s.

freimair · 2019-09-08T12:21:12Z

is there still something I should change?

chimp1984 · 2019-09-08T20:55:25Z

The filed inside the zip are executable, original files not.
Files in zip:

-rwxr-xr-x   1 user  staff   22 Sep  8 22:40 hostname
-rwxr-xr-x   1 user  staff  874 Sep  8 22:40 private_key

Original:

-rw-r--r--  1 user  staff   22 Sep  4 10:26 hostname
-rw-r--r--  1 user  staff  874 Sep  4 10:26 private_key

chimp1984 · 2019-09-08T20:57:25Z

Tested again backup and restore with app with no offers or trades open.

7jkfjawas3o3vu7k was original address. Backed it up, the renewed it. trkdvguyptjajozb was the new one. The I restored 7jkfjawas3o3vu7k.
Expected behaviour: I have only 7jkfjawas3o3vu7k as HS.
Result: I have both HS....

################################################################
Tor hidden service published after 31505 ms. Socked=HiddenServiceSocket[addr=7jkfjawas3o3vu7k.onion,port=9999]
.....

################################################################
Tor hidden service published after 33176 ms. Socked=HiddenServiceSocket[addr=trkdvguyptjajozb.onion,port=9999]

chimp1984 · 2019-09-08T20:57:41Z

NACK

freimair · 2019-09-09T06:18:01Z

ad backup and restore: that is expected. unused hidden services are cleaned up once a trade is complete and only after a restart of the application.

as for the executable flags: I do not see this behavior on my linux machine... onto it.

EDIT: zip by itself only stores files, no attributes. There are additional headers for storing such things but whether they are used and read properly strongly depends on the creator/reader software. I have seen different zip file viewers show different file mods on the same zip file. Hence, there is not a whole lot one can do against that.

Besides, it really does not matter here, as the files in the zip-file are text only.

freimair · 2019-09-10T12:58:30Z

is there anything else I should change?

devinbileck

NACK.
Based on my prior comment requiring validation during restore.

devinbileck · 2019-12-21T00:48:24Z

core/src/main/resources/i18n/displayStrings.properties

@@ -1073,6 +1073,15 @@ setting.preferences.dao.fullNodeInfo.cancel=No, I stick with lite node mode
 settings.net.btcHeader=Bitcoin network
 settings.net.p2pHeader=Bisq network
 settings.net.onionAddressLabel=My onion address
+settings.net.renewAddressButton=Create new address
+settings.net.renewAddress=Please be aware that you will loose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?


Suggested change

settings.net.renewAddress=Please be aware that you will loose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?

settings.net.renewAddress=Please be aware that you will lose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?

devinbileck · 2019-12-21T00:52:54Z

core/src/main/resources/i18n/displayStrings.properties

+settings.net.exportAddressFileEnding=Bisq Onion Address Backup (*.bisq)
+settings.net.importAddressButton=Restore address
+settings.net.importAddressFileDialog=Select the backup file
+settings.net.importAddress=Please be aware that you will loose your reputation when you restore a previous onion address (but restore your reputation connected to the restored onion address). Furthermore, you need to restart the application to set your new onion address active.


Suggested change

settings.net.importAddress=Please be aware that you will loose your reputation when you restore a previous onion address (but restore your reputation connected to the restored onion address). Furthermore, you need to restart the application to set your new onion address active.

settings.net.importAddress=Please be aware that you will lose your reputation when you restore a previous onion address (but restore your reputation connected to the restored onion address). Furthermore, you need to restart the application to set your new onion address active.

devinbileck · 2019-12-21T01:01:34Z

core/src/main/resources/i18n/displayStrings.properties

@@ -1073,6 +1073,15 @@ setting.preferences.dao.fullNodeInfo.cancel=No, I stick with lite node mode
 settings.net.btcHeader=Bitcoin network
 settings.net.p2pHeader=Bisq network
 settings.net.onionAddressLabel=My onion address
+settings.net.renewAddressButton=Create new address
+settings.net.renewAddress=Please be aware that you will loose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?


Perhaps we should emphasize the significance of this action. Although it wont remove the old address immediately if there are open offers/trades, they will not be able to back up the old address after creating a new address. So perhaps highly recommend that they backup prior to creating a new address if there are open trades/offers or perhaps even if there are closed trades (just in case).

devinbileck · 2019-12-21T01:02:33Z

core/src/main/resources/i18n/displayStrings.properties

+settings.net.exportAddressFileEnding=Bisq Onion Address Backup (*.bisq)
+settings.net.importAddressButton=Restore address
+settings.net.importAddressFileDialog=Select the backup file
+settings.net.importAddress=Please be aware that you will loose your reputation when you restore a previous onion address (but restore your reputation connected to the restored onion address). Furthermore, you need to restart the application to set your new onion address active.


As mentioned with renew address, perhaps we should emphasize the significance of this action as well.

ripcurlx

NACK - Could you please address #3044 (review)? Thanks!

ripcurlx · 2020-01-17T11:24:11Z

@freimair I activated yesterday codacy's PR Quality Review for the Bisq repository. It found for your PR a couple of issues which you can view in the Details link next to the PR check. Please review and push fixes for this issues to trigger a re-review by codacy. Thanks!

stale · 2020-02-16T12:01:26Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2020-02-23T12:33:39Z

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

freimair · 2020-02-28T15:33:24Z

this PR is postponed. it might be reactivated later. see bisq-network/projects#23

stale · 2020-10-11T11:40:35Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2020-10-18T17:05:12Z

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

freimair requested review from ripcurlx and sqrrm as code owners August 1, 2019 11:39

freimair mentioned this pull request Aug 1, 2019

Cycle 4 bisq-network/compensation#317

Closed

christophsturm reviewed Aug 5, 2019

View reviewed changes

core/src/main/java/bisq/core/trade/TradeManager.java Outdated Show resolved Hide resolved

freimair mentioned this pull request Aug 12, 2019

Cycle 5 bisq-network/compensation#336

Closed

ManfredKarrer suggested changes Aug 14, 2019

View reviewed changes

freimair changed the title ~~Backup, restore and create a new onion address via GUI~~ [WIP] Backup, restore and create a new onion address via GUI Aug 20, 2019

freimair changed the title ~~[WIP] Backup, restore and create a new onion address via GUI~~ Backup, restore and create a new onion address via GUI Aug 20, 2019

freimair mentioned this pull request Aug 27, 2019

Bisq does not validate Bitcoin P2P node at configuration time #3137

Closed

freimair force-pushed the export_import_renew_id branch 2 times, most recently from efa257d to 0ffe563 Compare September 5, 2019 15:00

freimair force-pushed the export_import_renew_id branch from 0ffe563 to 8b08774 Compare September 6, 2019 14:01

freimair requested a review from ManfredKarrer September 8, 2019 13:47

devinbileck suggested changes Dec 26, 2019

View reviewed changes

ripcurlx added the waiting for author label Jan 3, 2020

ripcurlx mentioned this pull request Jan 13, 2020

For Cycle 9 bisq-network/compensation#466

Closed

ripcurlx suggested changes Jan 13, 2020

View reviewed changes

devinbileck mentioned this pull request Jan 14, 2020

For Cycle 9 bisq-network/compensation#472

Closed

freimair mentioned this pull request Jan 15, 2020

For Cycle 10 bisq-network/compensation#474

Closed

freimair mentioned this pull request Feb 13, 2020

For Cycle 11 bisq-network/compensation#492

Closed

stale bot added the was:dropped label Feb 16, 2020

stale bot closed this Feb 23, 2020

freimair mentioned this pull request Mar 31, 2020

For Cycle 12 bisq-network/compensation#521

Closed

freimair mentioned this pull request Apr 22, 2020

For Cycle 13 bisq-network/compensation#549

Closed

freimair mentioned this pull request Jun 19, 2020

For Cycle 14 bisq-network/compensation#596

Closed

freimair mentioned this pull request Jul 16, 2020

For Cycle 15 bisq-network/compensation#611

Closed

This was referenced Sep 3, 2020

For Cycle 17 bisq-network/compensation#655

Closed

Migrate to Tor v3 onion service protocol bisq-network/projects#23

Closed

ripcurlx reopened this Sep 10, 2020

stale bot removed the was:dropped label Sep 10, 2020

stale bot added the was:dropped label Oct 11, 2020

stale bot closed this Oct 18, 2020

freimair mentioned this pull request Oct 20, 2020

For Cycle 18 bisq-network/compensation#685

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backup, restore and create a new onion address via GUI #3044

Backup, restore and create a new onion address via GUI #3044

freimair commented Aug 1, 2019 •

edited

Loading

ManfredKarrer commented Aug 14, 2019

ManfredKarrer commented Aug 14, 2019

ManfredKarrer left a comment

freimair commented Aug 14, 2019

ripcurlx commented Aug 20, 2019

freimair commented Aug 20, 2019 •

edited

Loading

freimair commented Aug 26, 2019

ripcurlx commented Aug 27, 2019

ManfredKarrer commented Aug 27, 2019

ripcurlx commented Sep 2, 2019

ManfredKarrer commented Sep 2, 2019

battleofwizards commented Sep 6, 2019

freimair commented Sep 8, 2019

chimp1984 commented Sep 8, 2019

chimp1984 commented Sep 8, 2019

chimp1984 commented Sep 8, 2019

freimair commented Sep 9, 2019 •

edited

Loading

freimair commented Sep 10, 2019

devinbileck left a comment

devinbileck Dec 21, 2019

devinbileck Dec 21, 2019

devinbileck Dec 21, 2019

devinbileck Dec 21, 2019

ripcurlx left a comment

ripcurlx commented Jan 17, 2020

stale bot commented Feb 16, 2020

stale bot commented Feb 23, 2020

freimair commented Feb 28, 2020 •

edited

Loading

stale bot commented Oct 11, 2020

stale bot commented Oct 18, 2020

	settings.net.renewAddress=Please be aware that you will loose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?
	settings.net.renewAddress=Please be aware that you will lose your reputation when you create and use a new onion address. Furthermore, you need to restart the application to set your new onion address active.\n\nProceed?

	settings.net.importAddress=Please be aware that you will loose your reputation when you restore a previous onion address (but restore your reputation connected to the restored onion address). Furthermore, you need to restart the application to set your new onion address active.
	settings.net.importAddress=Please be aware that you will lose your reputation when you restore a previous onion address (but restore your reputation connected to the restored onion address). Furthermore, you need to restart the application to set your new onion address active.

Backup, restore and create a new onion address via GUI #3044

Backup, restore and create a new onion address via GUI #3044

Conversation

freimair commented Aug 1, 2019 • edited Loading

ManfredKarrer commented Aug 14, 2019

ManfredKarrer commented Aug 14, 2019

ManfredKarrer left a comment

Choose a reason for hiding this comment

freimair commented Aug 14, 2019

ripcurlx commented Aug 20, 2019

freimair commented Aug 20, 2019 • edited Loading

freimair commented Aug 26, 2019

ripcurlx commented Aug 27, 2019

ManfredKarrer commented Aug 27, 2019

ripcurlx commented Sep 2, 2019

ManfredKarrer commented Sep 2, 2019

battleofwizards commented Sep 6, 2019

freimair commented Sep 8, 2019

chimp1984 commented Sep 8, 2019

chimp1984 commented Sep 8, 2019

chimp1984 commented Sep 8, 2019

freimair commented Sep 9, 2019 • edited Loading

freimair commented Sep 10, 2019

devinbileck left a comment

Choose a reason for hiding this comment

devinbileck Dec 21, 2019

Choose a reason for hiding this comment

devinbileck Dec 21, 2019

Choose a reason for hiding this comment

devinbileck Dec 21, 2019

Choose a reason for hiding this comment

devinbileck Dec 21, 2019

Choose a reason for hiding this comment

ripcurlx left a comment

Choose a reason for hiding this comment

ripcurlx commented Jan 17, 2020

stale bot commented Feb 16, 2020

stale bot commented Feb 23, 2020

freimair commented Feb 28, 2020 • edited Loading

stale bot commented Oct 11, 2020

stale bot commented Oct 18, 2020

freimair commented Aug 1, 2019 •

edited

Loading

freimair commented Aug 20, 2019 •

edited

Loading

freimair commented Sep 9, 2019 •

edited

Loading

freimair commented Feb 28, 2020 •

edited

Loading