Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce maximum trade size for unsigned payment accounts #7365

Conversation

HenrikJannsen
Copy link
Collaborator

@HenrikJannsen HenrikJannsen commented Jan 30, 2025

Implements bisq-network/proposals#470
Thought values are as in bisq-network/proposals#470 (comment)

Based on #7364

…for `SignedWitnessService.MINIMUM_TRADE_AMOUNT_FOR_SIGNING` instead of setting the value statically, as both are related.

Signed-off-by: HenrikJannsen <[email protected]>
…RADE_AMOUNT_CHANGE_ACTIVATION_DATE

Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
… without signed account to take it, and seller taking an offer of a buyer without signed account

Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
@HenrikJannsen HenrikJannsen force-pushed the Reduce-maximum-trade-size-for-unsigned-payment-accounts branch from aea6752 to 05b7eb9 Compare February 1, 2025 07:30
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 5699774 into bisq-network:master Feb 2, 2025
3 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.19 milestone Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants