feat: Check if Include folders/files do exists (in case they are removed)

[rafaelhdr]

Solution b) when start taking a snapshot the include list should be checked of existence first and warn about missings.

reference: #1586

[rafaelhdr]

This is not complete yet, but if possible I would like some feedback before finishing it.

Are the messages good? And I am wondering if the qt warning is ok (it is asking a confirmation before continuing instead of just warning).

And I didn't implement a) for no big reason. I am still getting familiar with the code and b) was something that was more clear for me. I could try a) in a future PR.

And how you normally do translations? I was planning to translate all other languages using some automated tool (Copilot) but I wanted to confirm how you guys do it normally...

[buhtz]

Dear Rafael,
Awesome! Thank you for this next contribution.

I added some comments and suggestions to the code. I am not sure about the whole solution. I would suggest to further discuss it in the related issue #1586.

I will set the PR into Draft mode to state the the solution is not finished.

Best,
Christian

[rafaelhdr]

I appreciate a lot for the review. It clarified a lot of questions and taught me some good lessons (I would never have thought about RTL issues on translations). And I am happy about not use the camel case :)

I will do the fixes from the review and wait for any suggestion in the original issue.

Thank you very much 🙏

[buhtz]

Does anyone know how to trigger the systray-icon message-bubbles via BIT?

I tried with "Snapshot.setTakeSnapshotMessage(1, 'FOO BAR')" but without success. This message appears in the status bar of the main window.

[buhtz]

I would never have thought about RTL issues on translations

Me neither. When I started to work on the translation task I thougt it is easy. I learned things like that from translators and the community around them while trying to attract translators to BIT.

[buhtz]

Hello Rafael,
can you give me a ping please. 🔔 What are your plans with this PR?

I suggest you to update your local branch to the latest dev version and integrate that into your PR.

1. Go to your own "rafaelhdr:backintime" fork at GitHub. Click on "Sync fork".
2. Go to your local machine and checkout the "dev" branch.
3. Run git fetch --prune --all.
4. Run git pull.
5. Checkout your branch check-included-do-exists.
6. Run git pull.
7. Merge dev into your branch via git merge dev.
8. Resolve merge conflicts if they are there. Don't worry, we can fix them later if somethings goes wrong.
9. Push it to this PR after committing it via git push.

As an alternative, I am also able to do the merging and conflict resolving on my side. Let me know.

[rafaelhdr]

Hello Sorry. End of the year I was so busy that I couldn't give proper attention. Right now I am on vacation, but I believe I can do the fixes in the beginning of January (around 5th of January) And thank you for all your help :)

…

On Sun, Dec 29, 2024, 09:49 Christian Buhtz ***@***.***> wrote: Hello Rafael, can you give me a ping please. 🔔 What are your plans with this PR? I suggest you to update your local branch to the latest dev version and integrate that into your PR. 1. Go to your own "rafaelhdr:backintime" fork at GitHub. Click on "Sync fork". 2. Go to your local machine and checkout the "dev" branch. 3. Run git fetch --prune --all. 4. Run git pull. 5. Checkout your branch check-included-do-exists. 6. Run git pull. 7. Merge dev into your branch via git merge dev. 8. Resolve merge conflicts if they are there. Don't worry, we can fix them later if somethings goes wrong. 9. Push it to this PR after committing it via git push. — Reply to this email directly, view it on GitHub <#1718 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIOX3IKHLFWLYEXFBSTLDD2H7ASLAVCNFSM6AAAAABHOQ23LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUGY3DSOBTGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[buhtz]

Great to hear. Don't feel rushed. I just want to know if you are still alive. Take your time.
Have a nice vacation.

[rafaelhdr]

Thank you. I just made latest fixes from review. I think it is ready again for review.

And I appreciate an extra manual review on it 🙏

[buhtz]

Thank you for your work. I commented just one minor suggestion.

After that I will test it on my machine.

[rafaelhdr]

All right. Thank you. Review done :)

aryoda is out of order

[rafaelhdr]

Thank you for all the help here 🙏

I see you merged it to dev. Is everything ok? Should I close this Pull Request?

[buhtz]

I see you merged it to dev.

No, I didn't. I did it the other direction. I merged "dev" into your branch. That means I updated your branch to reflect the latest changes in "dev".

Is everything ok?

On a first view I would say yes. But I will do some manual testing. But there is not hurry.

Have look at "Milestone" in the right sidebar. Keep in mind that this PR is scheduled for the release after the next release. This will take some weeks/months. I need to merge #1897 and then publish a release candidate (1.6.0-rc). I also have to finish all other tasks scheduled for Milestone 1.6.0. After releasing 1.6.0 we can step to the next milestone which includes your PR.

My goal is to keep 1.6.0 as stable as possible. So I try to minimize modifications on the code base. The reasons is that I want to have 1.6.0 in the next Debian stable (version 13) release. This might come in the second half of this year. Debian release do live 2 years or longer. This need to be stable and rock solid.

Should I close this Pull Request?

No. It will get closed automatically after I merged it.

[rafaelhdr]

Ooooh my bad 🤦‍♂️

When I saw the message, I understood wrong (that we merged this to dev)