-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay and Cooldown Decorators #276
Conversation
Consistent with time limit decorator
variable rename + more accurate documentation
Make sure that the delayer resets properly the next time it is ticked after its child has ran.
Now only resets after it actually runs its child
So it would seem that Edit 2: I Rewrote the test and now it passes consistently; the test was badly written originally. |
This is amazing, thank you! |
@RedstoneParadox can you please also add docs to the wiki about these new nodes? |
Docs added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thank you!
Description
Adds a new delay decorator, which allows nodes to be executed after a predetermined delay, which was discussed in #242.
Something also discussed was some way of implementing cooldowns for certain actions (i.e. a boss does an action but can't do it again for 10 seconds). My first thought was to add a mode to the delay decorator where it returnsEdit: Decided to implement it as a separate node.FAILURE
instead of running while the timer is running, but I wanted to see if it would be preferable to make a separate node.Addressed issues
Addresses #242