trezor: Return PASSPHRASE_ON_DEVICE if passphrase entry on device is available #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…available Somewhere between firmware versions 2.3.0 and 2.3.6, the Trezor T started using a slightly different message which results in our passphrase handling incorrectly giving the passphrase from the host instead of forcing passphrase entry on device. We fix this issue by returning the correct object to indicate that passphrase entry should occur on device.
achow101
force-pushed
the
trezor-t-pass-on-dev
branch
from
c8034af to
551d72f
Compare
|
I can confirm that this re-fixes #283 :) |
|
Does it work with the older firmware? Is this backward compatible? Is it possible to release a hotfix so we can test and update it? |
|
@nopara73 I've released 2.0.1 |
|
Thank you very much guys! The testing discussion will go under WalletWasabi/WalletWasabi#5465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere between firmware versions 2.3.0 and 2.3.6, the Trezor T started using a slightly different message which results in our passphrase handling incorrectly giving the passphrase from the host instead of forcing passphrase entry on device. We fix this issue by returning the correct object to indicate that passphrase entry should occur on device.