Skip to content

Commit

Permalink
Merge #695: download: Remove i686 Linux link
Browse files Browse the repository at this point in the history
fa73ac1 download: Remove i686 Linux links (MarcoFalke)

Pull request description:

  There is only one known user of the i686 linux binary, so it is planned to be removed from the build and quality assurance pipeline. The last user (or users) is encouraged to compile locally with `make check && ./test/functional/test_runner.py` to run the tests on their target system. Using clang, this is possible even on systems with 1 GB of ram. See bitcoin/bitcoin#17504

  Prepare this website and remove the download link from it early.

ACKs for top commit:
  harding:
    Tested ACK fa73ac1

Tree-SHA512: f904d00371d077bf2fb88e69bdde120db518926556a709bc438407a7a00b0572efa61798e48c58e90aeb6191ab2ce2d5846ee178c3a0b5c5f34023999a0cfb41
  • Loading branch information
harding committed Feb 6, 2020
2 parents e8515fd + fa73ac1 commit 11940dd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 16 deletions.
1 change: 0 additions & 1 deletion _data/binaries.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@ win64zip: "win64.zip"
win64exe: "win64-setup.exe"
macdmg: "-osx.dmg"
mactar: "osx64.tar.gz"
lin32: "i686-pc-linux-gnu.tar.gz"
lin64: "x86_64-linux-gnu.tar.gz"
riscv64: "riscv64-linux-gnu"
18 changes: 3 additions & 15 deletions _includes/templates/download.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% capture /dev/null %}<!-- suppress render of this part -->
<!-- Copyright 2013 - 2016 The Bitcoin.org Project.
Copyright 2017 - 2018 The BitcoinCore.org Project
Copyright 2017 - 2020 The BitcoinCore.org Project
This file is licensed under the MIT License (MIT) available on
http://opensource.org/licenses/MIT. -->
{% assign VERSION_SORTED_RELEASES = site.releases | sort: 'release' | reverse %}
Expand Down Expand Up @@ -41,9 +41,7 @@ <h2>{{ page.latestversion }} {{CURRENT_RELEASE}} <a type="application/rss+xml" h
<div>
<img src="/assets/images/os/med_linux.png" alt="linux">
<span>
<a href="{{ PATH_PREFIX }}/{{ FILE_PREFIX }}-{{ site.data.binaries.lin64 }}" id="downloadlin">Linux (tgz)</a>
<span><a href="{{ PATH_PREFIX }}/{{ FILE_PREFIX }}-{{ site.data.binaries.lin64 }}" class="dl" id="lin64">64 bit</a> -
<a href="{{ PATH_PREFIX }}/{{ FILE_PREFIX }}-{{ site.data.binaries.lin32 }}" class="dl" id="lin32">32 bit</a></span>
<a href="{{ PATH_PREFIX }}/{{ FILE_PREFIX }}-{{ site.data.binaries.lin64 }}" class="dl" id="lin64">Linux (tgz)</a>
</span>
</div>
</div>
Expand Down Expand Up @@ -251,21 +249,16 @@ <h2 style="text-align: center">{{page.build_reproduction}}</h2>
<script type="text/javascript">
var os = 'windows64';
if (navigator.userAgent.indexOf('Mac') != -1) var os = 'mac'
else if (navigator.userAgent.indexOf('Linux') != -1) {
var os='linux32';
if (navigator.userAgent.indexOf('x86_64') != -1) var os = 'linux64';
}
else if (navigator.userAgent.indexOf('Linux') != -1) var os = 'linux64'
else if (navigator.userAgent.indexOf('WOW64') != -1 || navigator.userAgent.indexOf('Win64') != -1) var os='windows64';
var but = document.getElementById('downloadbutton');
var linkwinexe = document.getElementById('downloadwinexe');
var linkwinzip = document.getElementById('downloadwinzip');
var linklin = document.getElementById('downloadlin');
var hrefwin64exe = document.getElementById('win64exe').href;
var hrefwin64zip = document.getElementById('win64zip').href;
var hrefmacdmg = document.getElementById('macdmg').href;
var hrefmactar = document.getElementById('mactar').href;
var hreflin64 = document.getElementById('lin64').href;
var hreflin32 = document.getElementById('lin32').href;
switch (os) {
case 'windows64':
but.getElementsByTagName('IMG')[0].src = '/assets/images/os/but_windows.svg';
Expand All @@ -278,11 +271,6 @@ <h2 style="text-align: center">{{page.build_reproduction}}</h2>
but.href = hreflin64;
linklin.href = hreflin64;
break;
case 'linux32':
but.getElementsByTagName('IMG')[0].src = '/assets/images/os/but_linux.png';
but.href = hreflin32;
linklin.href = hreflin32;
break;
case 'mac':
but.getElementsByTagName('IMG')[0].src = '/assets/images/os/but_mac.svg';
but.href = hrefmacdmg;
Expand Down

0 comments on commit 11940dd

Please sign in to comment.