Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant comment workflow permissions #1276

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

willcl-ark
Copy link
Member

Only require the minimal permissions to write a comment on a pull-request.

Allows repo-level workflow permissions to be set to read-only:

Read repository contents and packages permissions
Workflows have read permissions in the repository for the contents and packages scopes only.

Only grant the minimal permissions to write a comment on a
pull-request.
@fanquake fanquake merged commit 3436586 into bitcoin-core:main Jun 19, 2024
2 checks passed
@0xB10C
Copy link
Contributor

0xB10C commented Jun 19, 2024

ACK 065245b

From the docs for create an issue comment:

The fine-grained token must have at least one of the following permission sets:

  • "Issues" repository permissions (write)
  • "Pull requests" repository permissions (write)

The actions: read permissions don't seem to be required (or might already be granted) as can be seen in e.g. this runs download artifact step: https://github.com/bitcoin-core/guix.sigs/actions/runs/9579230000/job/26411233646#step:2:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants